beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Use correct cell address for HeapFunction captures in GC dumps

Browse source 
We were previously dumping the address of the cell pointer instead of
the address of the cell itself. This was causing mysterious orphans
in GC dumps, and it took me way too long to figure this out.
This commit is contained in:
Andreas Kling 2024-11-11 15:45:51 +01:00 committed by Andreas Kling
parent 7efc89e92b
commit e240084437
Notes: github-actions[bot] 2024-11-11 20:42:11 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e240084437e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2287
Reviewed-by: https://github.com/ADKaster
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Heap/Heap.cpp
View file

@ -152,7 +152,7 @@ public:
for_each_cell_among_possible_pointers(m_all_live_heap_blocks, possible_pointers, [&](Cell* cell, FlatPtr) {
if (m_node_being_visited)
m_node_being_visited->edges.set(reinterpret_cast<FlatPtr>(&cell));
m_node_being_visited->edges.set(reinterpret_cast<FlatPtr>(cell));
if (m_graph.get(reinterpret_cast<FlatPtr>(&cell)).has_value())
return;