beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Bake CLion IDE check into AK_COMPILER_CLANG

Browse source 
For whatever reason, when CLion does its code indexing thing, it doesn't
define __clang__ despite using Clang. This causes it to run into various
problems that we've solved by checking for Clang.

Since CLion does define __CLION_IDE__ (or sometimes __CLION_IDE_, no
idea why but I have seen this issue locally), let's make that part of
the AK_COMPILER_CLANG check.

This makes CLion stop highlighting various things as errors.
This commit is contained in:
Andreas Kling 2023-04-08 07:34:01 +02:00
parent 9264303f5d
commit e1f5aae632
Notes: sideshowbarker 2024-07-17 05:03:11 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/e1f5aae632
Pull-request: https://github.com/SerenityOS/serenity/pull/18227
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/CheckedFormatString.h
View file

@ -14,7 +14,7 @@
#ifdef ENABLE_COMPILETIME_FORMAT_CHECK
// FIXME: Seems like clang doesn't like calling 'consteval' functions inside 'consteval' functions quite the same way as GCC does,
// it seems to entirely forget that it accepted that parameters to a 'consteval' function to begin with.
# if defined(AK_COMPILER_CLANG) || defined(__CLION_IDE__) || defined(__CLION_IDE_)
# if defined(AK_COMPILER_CLANG)
# undef ENABLE_COMPILETIME_FORMAT_CHECK
# endif
#endif

4
AK/Platform.h
View file

@ -38,7 +38,7 @@
# define AK_ARCH_32_BIT
#endif
#if defined(__clang__)
#if defined(__clang__) || defined(__CLION_IDE__) || defined(__CLION_IDE_)
# define AK_COMPILER_CLANG
#elif defined(__GNUC__)
# define AK_COMPILER_GCC
@ -116,7 +116,7 @@
# define VALIDATE_IS_AARCH64() static_assert(false, "Trying to include aarch64 only header on non aarch64 platform");
#endif
#if !defined(AK_COMPILER_CLANG) && !defined(__CLION_IDE_) && !defined(__CLION_IDE__)
#if !defined(AK_COMPILER_CLANG)
# define AK_HAS_CONDITIONALLY_TRIVIAL
#endif

2
AK/StdLibExtras.h
View file

@ -8,7 +8,7 @@
#include <AK/Platform.h>
#if defined(AK_COMPILER_CLANG) || defined(__CLION_IDE__)
#if defined(AK_COMPILER_CLANG)
# pragma clang diagnostic ignored "-Wunqualified-std-cast-call"
#endif