beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Fire iframe load event on document close

Browse source 
This matches the behavior of other browsers.
This commit is contained in:
Tim Ledbetter 2024-10-08 01:08:49 +01:00 committed by Andreas Kling
parent 00487a7b25
commit e1eeb93cc6
Notes: github-actions[bot] 2024-10-08 04:55:47 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e1eeb93cc60
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1673
3 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/document-close-iframe-load-event.txt Normal file
View file

@ -0,0 +1 @@
Onload event fired

15
Tests/LibWeb/Text/input/HTML/document-close-iframe-load-event.html Normal file
View file

@ -0,0 +1,15 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
asyncTest(done => {
const iframe = document.createElement('iframe');
document.body.appendChild(iframe);
iframe.contentDocument.open();
iframe.onload = () => {
println("Onload event fired");
iframe.remove();
done();
};
iframe.contentDocument.close();
});
</script>

3
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -705,6 +705,9 @@ WebIDL::ExceptionOr<void> Document::close()
// FIXME: 6. Run the tokenizer, processing resulting tokens as they are emitted, and stopping when the tokenizer reaches the explicit "EOF" character or spins the event loop.
m_parser->run();
// AD-HOC: This ensures that a load event is fired if the node navigable's container is an iframe.
completely_finish_loading();
return {};
}