beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Allow unpaired surrogates in String.prototype.replace

Browse source 
This was resulting in a crash for the WPT test case:

https://wpt.live/xhr/send-data-string-invalid-unicode.any.html
This commit is contained in:
Shannon Booth 2024-11-10 22:50:29 +13:00 committed by Tim Flynn
parent db47cc41f8
commit e02ca0480f
Notes: github-actions[bot] 2024-11-10 14:14:55 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e02ca0480f7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2265
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/AbstractOperations.cpp
View file

@ -1401,7 +1401,7 @@ ThrowCompletionOr<String> get_substitution(VM& vm, Utf16View const& matched, Utf
}
// 6. Return result.
return MUST(Utf16View { result }.to_utf8());
return MUST(Utf16View { result }.to_utf8(Utf16View::AllowInvalidCodeUnits::Yes));
}
// 2.1.2 AddDisposableResource ( disposable, V, hint [ , method ] ), https://tc39.es/proposal-explicit-resource-management/#sec-adddisposableresource-disposable-v-hint-disposemethod

6
Libraries/LibJS/Tests/builtins/String/String.prototype.replace.js
View file

@ -254,3 +254,9 @@ test("substitution with capture group", () => {
expect("A".replace(/(A)/, "$10")).toBe("A0");
expect("A".replace(/(A)/, "$2")).toBe("$2");
});
test("Replace with unpaired surrogate", () => {
expect("$".replace("$", "\ud83d")).toBe("\ud83d");
expect("$ab".replace("$", "\ud83d")).toBe("\ud83dab");
expect("\ud83d$ab".replace("\ud83d$", "ab")).toBe("abab");
});