From a7aed6ba352a611d075add3871c3ccc100e64abf Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Wed, 2 Oct 2024 13:03:07 -0700 Subject: [PATCH] Meta: Account for platform specific linking On Windows, similar to AIX, we would link against the import library rather than the actual library (at least when doing dynamic linking). Adjust the `libs` setting to allow linking properly on Windows. This reduces the number of undefined symbols when linking AK to 1. --- Meta/gn/build/libs/simdutf/BUILD.gn | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Meta/gn/build/libs/simdutf/BUILD.gn b/Meta/gn/build/libs/simdutf/BUILD.gn index bb76497dc50..4e2aea514f4 100644 --- a/Meta/gn/build/libs/simdutf/BUILD.gn +++ b/Meta/gn/build/libs/simdutf/BUILD.gn @@ -1,6 +1,10 @@ import("//Meta/gn/build/libs/third_party.gni") third_party_dependency("simdutf") { - libs = [ "simdutf" ] + if (current_os == "win") { + libs = [ "simdutf.lib" ] + } else { + libs = [ "simdutf" ] + } extra_public_configs = [ "//Meta/gn/build:pic" ] }