beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Implement acos<T> correctly

Browse source 
This is a naive implementation based on the symmetry with `asin`.

Before, I'm not really sure what we were doing, but it was returning
wildly incorrect results.
This commit is contained in:
Jelle Raaijmakers 2021-11-18 16:16:57 +01:00 committed by Andreas Kling
parent 9ea5a00e24
commit dfbdd035da
Notes: sideshowbarker 2024-07-18 01:01:17 +09:00 
Author: https://github.com/gmta
Commit: https://github.com/SerenityOS/serenity/commit/dfbdd035daf
Pull-request: https://github.com/SerenityOS/serenity/pull/10958
Reviewed-by: https://github.com/Hendiadyoin1
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/Math.h
View file

@ -250,7 +250,7 @@ constexpr T acos(T value)
CONSTEXPR_STATE(acos, value); CONSTEXPR_STATE(acos, value);
// FIXME: I am naive // FIXME: I am naive
return Pi<T> + asin(value); return static_cast<T>(0.5) * Pi<T> - asin<T>(value);
} }
template<FloatingPoint T> template<FloatingPoint T>

8
Tests/LibM/test-math.cpp
View file

@ -259,3 +259,11 @@ TEST_CASE(fmax_and_fmin)
EXPECT(fmin(0, NAN) == 0); EXPECT(fmin(0, NAN) == 0);
EXPECT(isnan(fmin(NAN, NAN))); EXPECT(isnan(fmin(NAN, NAN)));
} }
TEST_CASE(acos)
{
EXPECT_APPROXIMATE(acos(-1), M_PI);
EXPECT_APPROXIMATE(acos(0), 0.5 * M_PI);
EXPECT_APPROXIMATE(acos(1), 0);
EXPECT(isnan(acos(1.1)));
}