beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel: Return proper errno codes from Coredump::write_regions method

Browse source
This commit is contained in:
Liav A 2023-02-04 14:35:57 +02:00 committed by Linus Groh
parent 2d1719da73
commit df72c9327b
Notes: sideshowbarker 2024-07-17 05:41:34 +09:00 
Author: https://github.com/supercomputer7
Commit: https://github.com/SerenityOS/serenity/commit/df72c9327b
Pull-request: https://github.com/SerenityOS/serenity/pull/17308
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Kernel/Coredump.cpp
View file

@ -228,11 +228,15 @@ ErrorOr<void> Coredump::write_regions()
TRY(m_process->address_space().with([&](auto& space) -> ErrorOr<void> {
auto* real_region = space->region_tree().regions().find(region.vaddr().get());
if (!real_region)
return Error::from_string_view("Failed to find matching region in the process"sv);
if (!real_region) {
dmesgln("Coredump::write_regions: Failed to find matching region in the process");
return Error::from_errno(EFAULT);
}
if (!region.is_consistent_with_region(*real_region))
return Error::from_string_view("Found region does not match stored metadata"sv);
if (!region.is_consistent_with_region(*real_region)) {
dmesgln("Coredump::write_regions: Found region does not match stored metadata");
return Error::from_errno(EINVAL);
}
// If we crashed in the middle of mapping in Regions, they do not have a page directory yet, and will crash on a remap() call
if (!real_region->is_mapped())