beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibEDID: Fix DetailedTiming::pixel_clock_khz result

Browse source 
The stored value is in units of 10 kHz, which means that to get the
value in kHz, we need to multiply it by 10 and not 10000.
This commit is contained in:
Liav A 2022-03-05 22:08:10 +02:00 committed by Andreas Kling
parent ebbf977be5
commit df5fa20bee
Notes: sideshowbarker 2024-07-17 17:46:37 +09:00 
Author: https://github.com/supercomputer7
Commit: https://github.com/SerenityOS/serenity/commit/df5fa20bee
Pull-request: https://github.com/SerenityOS/serenity/pull/12894
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibEDID/EDID.cpp
View file

@ -665,7 +665,9 @@ Optional<FixedPoint<16>> Parser::gamma() const
u32 Parser::DetailedTiming::pixel_clock_khz() const
{
return (u32)m_edid.read_le(&m_detailed_timings.pixel_clock) * 10000;
// Note: The stored value is in units of 10 kHz, which means that to get the
// value in kHz, we need to multiply it by 10.
return (u32)m_edid.read_le(&m_detailed_timings.pixel_clock) * 10;
}
u16 Parser::DetailedTiming::horizontal_addressable_pixels() const
@ -768,7 +770,8 @@ FixedPoint<16, u32> Parser::DetailedTiming::refresh_rate() const
if (total_pixels == 0)
return {};
// Use a bigger fixed point representation due to the large numbers involved and then downcast
return FixedPoint<32, u64>(pixel_clock_khz()) / total_pixels;
// Note: We need to convert the pixel clock from kHz to Hertz to actually calculate this correctly.
return FixedPoint<32, u64>(pixel_clock_khz() * 1000) / total_pixels;
}
ErrorOr<IterationDecision> Parser::for_each_established_timing(Function<IterationDecision(EstablishedTiming const&)> callback) const