beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Actually perform "update the href steps"

Browse source 
We completely missed this step, which made setters not actually do
anything!

Fixes 336 test failures on:

https://wpt.live/url/url-setters-a-area.window.html
This commit is contained in:
Shannon Booth 2024-08-08 22:26:59 +12:00 committed by Tim Ledbetter
parent 40742d95e6
commit deff8df2c7
Notes: github-actions[bot] 2024-08-08 14:00:35 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/deff8df2c79
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1009
3 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/HTML/a-element-set-protocol-on-href.txt Normal file
View file

@ -0,0 +1,2 @@
http:
https:

10
Tests/LibWeb/Text/input/HTML/a-element-set-protocol-on-href.html Normal file
View file

@ -0,0 +1,10 @@
<a id="a" href="http://serenityos.org"></a>
<script src="../include.js"></script>
<script>
test(() => {
const aElement = document.getElementById("a");
println(a.protocol);
a.protocol = "https";
println(a.protocol);
})
</script>

1
Userland/Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View file

@ -449,6 +449,7 @@ WebIDL::ExceptionOr<void> HTMLHyperlinkElementUtils::set_href(String href)
void HTMLHyperlinkElementUtils::update_href()
{
// To update href, set the element's href content attribute's value to the element's url, serialized.
MUST(set_hyperlink_element_utils_href(MUST(String::from_byte_string(m_url->serialize()))));
}
bool HTMLHyperlinkElementUtils::cannot_navigate() const