beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibCrypto: Move some data around earlier in GHash to make it go faster

Browse source 
This makes galois_multiply() about 10% faster.
This commit is contained in:
Ali Mohammad Pur 2024-05-13 15:22:05 +02:00 committed by Andreas Kling
parent 57714fbb38
commit def379ce3f
Notes: sideshowbarker 2024-07-16 23:34:44 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/def379ce3f
Pull-request: https://github.com/SerenityOS/serenity/pull/24313
Reviewed-by: https://github.com/Zaggy1024
2 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Tests/LibCrypto/TestAES.cpp
View file

@ -336,6 +336,17 @@ TEST_CASE(test_AES_CTR_128bit_decrypt_16bytes)
// If encryption works, then decryption works, too.
}
BENCHMARK_CASE(GCM)
{
Crypto::Authentication::GHash ghash("WellHelloFriends"_b);
auto v = ByteBuffer::create_uninitialized(16 * MiB).release_value();
fill_with_random(v);
for (size_t i = 0; i < 10; ++i) {
ghash.process(v, "test"_b);
AK::taint_for_optimizer(v);
}
}
TEST_CASE(test_AES_GCM_name)
{
Crypto::Cipher::AESCipher::GCMMode cipher("WellHelloFriends"_b, 128, Crypto::Cipher::Intent::Encryption);

12
Userland/Libraries/LibCrypto/Authentication/GHash.cpp
View file

@ -86,13 +86,15 @@ GHash::TagType GHash::process(ReadonlyBytes aad, ReadonlyBytes cipher)
/// Galois Field multiplication using <x^127 + x^7 + x^2 + x + 1>.
/// Note that x, y, and z are strictly BE.
void galois_multiply(u32 (&z)[4], u32 const (&_x)[4], u32 const (&_y)[4])
void galois_multiply(u32 (&_z)[4], u32 const (&_x)[4], u32 const (&_y)[4])
{
// Note: Copied upfront to stack to avoid memory access in the loop.
u32 x[4] { _x[0], _x[1], _x[2], _x[3] };
u32 y[4] { _y[0], _y[1], _y[2], _y[3] };
__builtin_memset(z, 0, sizeof(z));
u32 const y[4] { _y[0], _y[1], _y[2], _y[3] };
u32 z[4] { 0, 0, 0, 0 };
#pragma GCC unroll 16
// Unrolled by 32, the access in y[3-(i/32)] can be cached throughout the loop.
#pragma GCC unroll 32
for (ssize_t i = 127; i > -1; --i) {
auto r = -((y[3 - (i / 32)] >> (i % 32)) & 1);
z[0] ^= x[0] & r;
@ -113,6 +115,8 @@ void galois_multiply(u32 (&z)[4], u32 const (&_x)[4], u32 const (&_y)[4])
x[0] ^= 0xe1000000 & -a3;
}
memcpy(_z, z, sizeof(z));
}
}