beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Inherit CSS variables across shadow boundaries

Browse source 
This fixes a bunch of issues on https://wpt.fyi/
This commit is contained in:
Andreas Kling 2024-07-25 21:04:39 +02:00 committed by Andreas Kling
parent cf6929fef3
commit de2b9eebe6
Notes: github-actions[bot] 2024-07-25 19:39:22 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/de2b9eebe60
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/835
3 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/ShadowDOM/css-variable-inheritance-across-shadow-boundary.txt Normal file
View file

@ -0,0 +1 @@
green rgb(0, 128, 0)

20
Tests/LibWeb/Text/input/ShadowDOM/css-variable-inheritance-across-shadow-boundary.html Normal file
View file

@ -0,0 +1,20 @@
<style>
:root {
--foo: green;
}
</style>
<div id="myShadowHost">
<template shadowrootmode="open">
<style>
span { color: var(--foo, red); }
</style>
<span>green</span>
</template>
</div>
<script src="../include.js"></script>
<script>
test(() => {
let span = myShadowHost.shadowRoot.firstElementChild.nextElementSibling;
println(getComputedStyle(span).color);
});
</script>

2
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -7651,7 +7651,7 @@ static RefPtr<StyleValue const> get_custom_property(DOM::Element const& element,
return it->value.value;
}
for (auto const* current_element = &element; current_element; current_element = current_element->parent_element()) {
for (auto const* current_element = &element; current_element; current_element = current_element->parent_or_shadow_host_element()) {
if (auto it = current_element->custom_properties({}).find(custom_property_name); it != current_element->custom_properties({}).end())
return it->value.value;
}