From dd88ff70acc20f6abb0a2fbb374da369e0c73e8c Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Tue, 4 Jan 2022 13:27:43 -0500 Subject: [PATCH] LibUnicode: Remove now unused value-from-string generator overload --- .../CodeGenerators/LibUnicode/GeneratorUtil.h | 53 ------------------- 1 file changed, 53 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h index 18d73315b35..74621fbbc28 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h +++ b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h @@ -345,59 +345,6 @@ Optional<@return_type@> @method_name@(StringView key) )~~~"); } -template -void generate_value_from_string_for_dynamic_loading(SourceGenerator& generator, StringView method_name_format, StringView value_type, StringView value_name, HashValueMap hashes, Optional return_type = {}, StringView return_format = "{}"sv) -{ - ensure_from_string_types_are_generated(generator); - - generator.set("method_name", String::formatted(method_name_format, value_name)); - generator.set("value_type", value_type); - generator.set("value_name", value_name); - generator.set("return_type", return_type.has_value() ? *return_type : value_type); - generator.set("size", String::number(hashes.size())); - - generator.append(R"~~~( -Optional<@return_type@> @method_name@(StringView key) asm("unicode_@method_name@"); -Optional<@return_type@> @method_name@(StringView key) -{ - constexpr Array, @size@> hash_pairs { { - )~~~"); - - auto hash_keys = hashes.keys(); - quick_sort(hash_keys); - - constexpr size_t max_values_per_row = 10; - size_t values_in_current_row = 0; - - for (auto hash_key : hash_keys) { - if (values_in_current_row++ > 0) - generator.append(" "); - - if constexpr (IsIntegral) - generator.set("value"sv, String::number(hashes.get(hash_key).value())); - else - generator.set("value"sv, String::formatted("{}::{}", value_type, hashes.get(hash_key).value())); - - generator.set("hash"sv, String::number(hash_key)); - generator.append("{ @hash@U, @value@ },"sv); - - if (values_in_current_row == max_values_per_row) { - generator.append("\n "); - values_in_current_row = 0; - } - } - - generator.set("return_statement", String::formatted(return_format, "value->value"sv)); - generator.append(R"~~~( - } }; - - if (auto const* value = binary_search(hash_pairs, key.hash(), nullptr, HashValueComparator<@value_type@> {})) - return @return_statement@; - return {}; -} -)~~~"); -} - template void generate_enum(SourceGenerator& generator, IdentifierFormatter&& format_identifier, StringView name, StringView default_, Vector& values, Vector aliases = {}) {