beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibC: Hide posix_memalign by default

Browse source 
This should keep ports from preferring `posix_memalign` over other
implementations of aligned memory.
This commit is contained in:
Tim Schumacher 2022-05-03 13:01:14 +02:00 committed by Andreas Kling
parent 45995aaeb6
commit dcd76db319
Notes: sideshowbarker 2024-07-17 11:22:07 +09:00 
Author: https://github.com/timschumi
Commit: https://github.com/SerenityOS/serenity/commit/dcd76db319
Pull-request: https://github.com/SerenityOS/serenity/pull/13897
3 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibC/CMakeLists.txt
View file

@ -139,6 +139,9 @@ set(SOURCES ${LIBC_SOURCES} ${AK_SOURCES} ${ELF_SOURCES} ${ASM_SOURCES})
# Prevent GCC from removing null checks by marking the `FILE*` argument non-null
set_source_files_properties(stdio.cpp PROPERTIES COMPILE_FLAGS "-fno-builtin-fputc -fno-builtin-fputs -fno-builtin-fwrite")
# Add in the `posix_memalign` symbol to avoid breaking existing binaries.
set_source_files_properties(stdlib.cpp PROPERTIES COMPILE_FLAGS "-DSERENITY_LIBC_SHOW_POSIX_MEMALIGN")
add_library(LibCStaticWithoutDeps STATIC ${SOURCES})
target_link_libraries(LibCStaticWithoutDeps PUBLIC ssp LibTimeZone PRIVATE NoCoverage)
add_dependencies(LibCStaticWithoutDeps LibM LibSystem LibUBSanitizer)

2
Userland/Libraries/LibC/stdlib.cpp
View file

@ -1336,6 +1336,7 @@ void _Exit(int status)
_exit(status);
}
#ifdef SERENITY_LIBC_SHOW_POSIX_MEMALIGN
// https://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_memalign.html
int posix_memalign(void** memptr, size_t alignment, size_t size)
{
@ -1344,3 +1345,4 @@ int posix_memalign(void** memptr, size_t alignment, size_t size)
(void)size;
TODO();
}
#endif

5
Userland/Libraries/LibC/stdlib.h
View file

@ -101,6 +101,11 @@ int posix_openpt(int flags);
int grantpt(int fd);
int unlockpt(int fd);
// FIXME: Remove the ifdef once we have a working memalign implementation.
// This is hidden by default until then because many applications prefer
// `posix_memalign` over other implementations of aligned memory.
#ifdef SERENITY_LIBC_SHOW_POSIX_MEMALIGN
int posix_memalign(void**, size_t alignment, size_t size);
#endif
__END_DECLS