beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Make factory method of Selection::Selection fallible

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-19 18:39:04 +01:00 committed by Andreas Kling
parent d69e863286
commit dcbe927b48
Notes: sideshowbarker 2024-07-17 09:39:38 +09:00 
Author: https://github.com/kennethmyhra
Commit: https://github.com/SerenityOS/serenity/commit/dcbe927b48
Pull-request: https://github.com/SerenityOS/serenity/pull/17542
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -378,7 +378,7 @@ JS::GCPtr<Selection::Selection> Document::get_selection()
}
if (!m_selection) {
m_selection = Selection::Selection::create(realm(), *this);
m_selection = Selection::Selection::create(realm(), *this).release_value_but_fixme_should_propagate_errors();
}
return m_selection;
}

4
Userland/Libraries/LibWeb/Selection/Selection.cpp
View file

@ -11,9 +11,9 @@
namespace Web::Selection {
JS::NonnullGCPtr<Selection> Selection::create(JS::NonnullGCPtr<JS::Realm> realm, JS::NonnullGCPtr<DOM::Document> document)
WebIDL::ExceptionOr<JS::NonnullGCPtr<Selection>> Selection::create(JS::NonnullGCPtr<JS::Realm> realm, JS::NonnullGCPtr<DOM::Document> document)
{
return realm->heap().allocate<Selection>(realm, realm, document).release_allocated_value_but_fixme_should_propagate_errors();
return MUST_OR_THROW_OOM(realm->heap().allocate<Selection>(realm, realm, document));
}
Selection::Selection(JS::NonnullGCPtr<JS::Realm> realm, JS::NonnullGCPtr<DOM::Document> document)

2
Userland/Libraries/LibWeb/Selection/Selection.h
View file

@ -15,7 +15,7 @@ class Selection final : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(Selection, Bindings::PlatformObject);
public:
static JS::NonnullGCPtr<Selection> create(JS::NonnullGCPtr<JS::Realm>, JS::NonnullGCPtr<DOM::Document>);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<Selection>> create(JS::NonnullGCPtr<JS::Realm>, JS::NonnullGCPtr<DOM::Document>);
virtual ~Selection() override;