beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Increase completed jobs number even if navigable is destroyed

Browse source 
...otherwise spin_until() will stuck waiting.
This commit is contained in:
Aliaksandr Kalenik 2024-04-05 02:46:32 +02:00 committed by Andreas Kling
parent aefed21927
commit db31fa730a
Notes: sideshowbarker 2024-07-17 22:55:25 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/db31fa730a
Pull-request: https://github.com/SerenityOS/serenity/pull/23844
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View file

@ -454,8 +454,10 @@ TraversableNavigable::HistoryStepResult TraversableNavigable::apply_the_history_
for (auto& navigable : changing_navigables) {
queue_global_task(Task::Source::NavigationAndTraversal, *navigable->active_window(), [&] {
// NOTE: This check is not in the spec but we should not continue navigation if navigable has been destroyed.
if (navigable->has_been_destroyed())
if (navigable->has_been_destroyed()) {
completed_change_jobs++;
return;
}
// 1. Let displayedEntry be navigable's active session history entry.
auto displayed_entry = navigable->active_session_history_entry();