beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Terminal: Remove working directory argument

Browse source 
Applications that want to spawn Terminal in a specific
directory should chdir to it before execing it.
This commit is contained in:
Itamar 2020-03-16 22:31:35 +02:00 committed by Andreas Kling
parent c18f12bb96
commit d98fbd192e
Notes: sideshowbarker 2024-07-19 08:15:51 +09:00 
Author: https://github.com/itamar8910
Commit: https://github.com/SerenityOS/serenity/commit/d98fbd192e5
Pull-request: https://github.com/SerenityOS/serenity/pull/1477
Reviewed-by: https://github.com/bugaevc
1 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Applications/Terminal/main.cpp
View file

@ -197,23 +197,12 @@ int main(int argc, char** argv)
} }
const char* command_to_execute = nullptr; const char* command_to_execute = nullptr;
const char* working_directory_chars = nullptr;
Core::ArgsParser args_parser; Core::ArgsParser args_parser;
args_parser.add_option(command_to_execute, "Execute this command inside the terminal", nullptr, 'e', "command"); args_parser.add_option(command_to_execute, "Execute this command inside the terminal", nullptr, 'e', "command");
args_parser.add_option(working_directory_chars, "Set the working directory", nullptr, 'd', "directory");
args_parser.parse(argc, argv); args_parser.parse(argc, argv);
String working_directory(working_directory_chars);
if (working_directory.is_empty()) {
working_directory = get_current_user_home_path();
}
if (chdir(working_directory.characters()) < 0)
perror("chdir");
int ptm_fd = posix_openpt(O_RDWR | O_CLOEXEC); int ptm_fd = posix_openpt(O_RDWR | O_CLOEXEC);
if (ptm_fd < 0) { if (ptm_fd < 0) {
perror("posix_openpt"); perror("posix_openpt");