From d8cfe79a20659a4ee6f8a8fa298a178d4f1f9152 Mon Sep 17 00:00:00 2001
From: Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
Date: Fri, 25 Aug 2023 13:39:32 +0200
Subject: [PATCH] LibWeb: Call process_the_iframe_attributes if iframe
 attribute changed

Replaces `load_src()` with `process_the_iframe_attributes()`. Both load
document of iframe but the latter is defined in spec.
---
 .../LibWeb/HTML/HTMLIFrameElement.cpp         | 26 ++-----------------
 .../Libraries/LibWeb/HTML/HTMLIFrameElement.h |  2 --
 2 files changed, 2 insertions(+), 26 deletions(-)

diff --git a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
index 63a50239688..a2d51fee3eb 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
+++ b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
@@ -35,8 +35,8 @@ JS::GCPtr<Layout::Node> HTMLIFrameElement::create_layout_node(NonnullRefPtr<CSS:
 void HTMLIFrameElement::attribute_changed(DeprecatedFlyString const& name, DeprecatedString const& value)
 {
     HTMLElement::attribute_changed(name, value);
-    if (name == HTML::AttributeNames::src)
-        load_src(value);
+    if (m_nested_browsing_context)
+        process_the_iframe_attributes();
 }
 
 // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:the-iframe-element-6
@@ -109,28 +109,6 @@ void HTMLIFrameElement::removed_from(DOM::Node* node)
     }
 }
 
-void HTMLIFrameElement::load_src(DeprecatedString const& value)
-{
-    if (!m_nested_browsing_context)
-        return;
-
-    if (value.is_null())
-        return;
-
-    auto url = document().parse_url(value);
-    if (!url.is_valid()) {
-        dbgln("iframe failed to load URL: Invalid URL: {}", value);
-        return;
-    }
-    if (url.scheme() == "file" && document().origin().scheme() != "file") {
-        dbgln("iframe failed to load URL: Security violation: {} may not load {}", document().url(), url);
-        return;
-    }
-
-    dbgln("Loading iframe document from {}", value);
-    m_nested_browsing_context->loader().load(url, FrameLoader::Type::IFrame);
-}
-
 // https://html.spec.whatwg.org/multipage/rendering.html#attributes-for-embedded-content-and-images
 void HTMLIFrameElement::apply_presentational_hints(CSS::StyleProperties& style) const
 {
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
index b618f064432..413057cc9a2 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
+++ b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
@@ -39,8 +39,6 @@ private:
     // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes
     void process_the_iframe_attributes(bool initial_insertion = false);
 
-    void load_src(DeprecatedString const&);
-
     // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#current-navigation-was-lazy-loaded
     bool m_current_navigation_was_lazy_loaded { false };
 };