beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb/Meta: Adjust how missing/invalid default values are generated

Browse source
This commit is contained in:
stelar7 2024-10-21 02:03:11 +02:00 committed by Andreas Kling
parent a8d0712c28
commit d81f31c699
Notes: github-actions[bot] 2024-10-21 08:35:17 +00:00 
Author: https://github.com/stelar7
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d81f31c6993
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1892
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -3499,21 +3499,24 @@ JS_DEFINE_NATIVE_FUNCTION(@class_name@::@attribute.getter_callback@)
// or that it is in a state of attributeDefinition with no associated keyword value, then return the empty string.
// NOTE: @invalid_enum_default_value@ is set to the empty string if it isn't present.
attribute_generator.append(R"~~~(
if (!contentAttributeValue.has_value())
auto did_set_to_missing_value = false;
if (!contentAttributeValue.has_value()) {
retval = "@missing_enum_default_value@"_string;
did_set_to_missing_value = true;
}
Array valid_values { @valid_enum_values@ };
auto found = false;
auto has_keyword = false;
for (auto const& value : valid_values) {
if (value.equals_ignoring_ascii_case(retval)) {
found = true;
has_keyword = true;
retval = value;
break;
}
}
if (!found)
if (!has_keyword && !did_set_to_missing_value)
retval = "@invalid_enum_default_value@"_string;
)~~~");