beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

headless-browser: Ensure IPC::File is closed after sending

Browse source 
On systems with the default ulimit for open files <= 256 (default
on some systems) the LibWeb tests were crashing because the
input file handles are not closed in headless-browser.
This commit is contained in:
Sebastian Zaha 2023-07-06 22:41:25 +02:00 committed by Andreas Kling
parent 59c862cab9
commit d77986f01c
Notes: sideshowbarker 2024-07-17 05:19:06 +09:00 
Author: https://github.com/SebastianZaha
Commit: https://github.com/SerenityOS/serenity/commit/d77986f01c
Pull-request: https://github.com/SerenityOS/serenity/pull/19853
Reviewed-by: https://github.com/linusg
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/headless-browser.cpp
View file

@ -120,7 +120,7 @@ private:
if (file.is_error())
client().async_handle_file_return(file.error().code(), {}, request_id);
else
client().async_handle_file_return(0, IPC::File(*file.value()), request_id);
client().async_handle_file_return(0, IPC::File(*file.value(), IPC::File::CloseAfterSending), request_id);
}
void notify_server_did_finish_handling_input_event(bool) override { }