beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Let lambdas return WebIDL::ExceptionOr in XHR::send()

Browse source 
Instead of ErrorOr let these lambdas return WebIdL::ExceptionOr. This
patch also cleans up this part so it's a bit more readable.
This commit is contained in:
Kenneth Myhra 2022-10-09 22:33:51 +02:00 committed by Ali Mohammad Pur
parent afeff4cebb
commit d5247ae33e
Notes: sideshowbarker 2024-07-17 06:40:21 +09:00 
Author: https://github.com/kennethmyhra
Commit: https://github.com/SerenityOS/serenity/commit/d5247ae33e
Pull-request: https://github.com/SerenityOS/serenity/pull/15620
Reviewed-by: https://github.com/linusg ✅
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -433,12 +433,19 @@ WebIDL::ExceptionOr<void> XMLHttpRequest::send(Optional<Fetch::XMLHttpRequestBod
auto request = LoadRequest::create_for_url_on_page(request_url, m_window->page());
request.set_method(m_method);
if (body_with_type.has_value()) {
TRY_OR_RETURN_OOM(realm, body_with_type->body.source().visit([&](ByteBuffer const& buffer) -> ErrorOr<void> {
TRY(body_with_type->body.source().visit(
[&](ByteBuffer const& buffer) -> WebIDL::ExceptionOr<void> {
request.set_body(buffer);
return {}; }, [&](JS::Handle<FileAPI::Blob> const& blob) -> ErrorOr<void> {
auto byte_buffer = TRY(ByteBuffer::copy(blob->bytes()));
return {};
},
[&](JS::Handle<FileAPI::Blob> const& blob) -> WebIDL::ExceptionOr<void> {
auto byte_buffer = TRY_OR_RETURN_OOM(realm, ByteBuffer::copy(blob->bytes()));
request.set_body(byte_buffer);
return {}; }, [](auto&) -> ErrorOr<void> { return {}; }));
return {};
},
[](auto&) -> WebIDL::ExceptionOr<void> {
return {};
}));
if (body_with_type->type.has_value()) {
// If type is non-null and this’s headers’s header list does not contain `Content-Type`, then append (`Content-Type`, type) to this’s headers.
if (!m_request_headers.contains("Content-Type"sv))