beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibGfx/TIFF: Also cache the result of alpha_channel_index()

Browse source 
This function was called over and over in `manage_extra_channels()`,
even if the result depends only on the metadata. Instead, we now call it
once and store the result.
This commit is contained in:
Lucas CHOLLET 2024-02-15 20:55:35 -05:00 committed by Jelle Raaijmakers
parent a637a02de8
commit d375b5c2a5
Notes: sideshowbarker 2024-07-16 22:18:54 +09:00 
Author: https://github.com/LucasChollet
Commit: https://github.com/SerenityOS/serenity/commit/d375b5c2a5
Pull-request: https://github.com/SerenityOS/serenity/pull/23213
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/nico ✅
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
View file

@ -116,6 +116,7 @@ public:
m_image_width = m_metadata.image_width().value();
if (m_metadata.predictor().has_value())
m_predictor = m_metadata.predictor().value();
m_alpha_channel_index = alpha_channel_index();
}
ErrorOr<void> decode_frame()
@ -213,12 +214,11 @@ private:
// them, conserve the alpha value (if any) and discard everything else.
auto const number_base_channels = samples_for_photometric_interpretation();
auto const alpha_index = alpha_channel_index();
Optional<u8> alpha {};
for (u8 i = number_base_channels; i < m_bits_per_sample.size(); ++i) {
if (alpha_index == i)
if (m_alpha_channel_index == i)
alpha = TRY(read_component(stream, m_bits_per_sample[i]));
else
TRY(read_component(stream, m_bits_per_sample[i]));
@ -344,7 +344,7 @@ private:
color.set_red(last_color->red() + color.red());
color.set_green(last_color->green() + color.green());
color.set_blue(last_color->blue() + color.blue());
if (alpha_channel_index().has_value())
if (m_alpha_channel_index.has_value())
color.set_alpha(last_color->alpha() + color.alpha());
}
@ -686,6 +686,8 @@ private:
Vector<u32, 4> m_bits_per_sample {};
u32 m_image_width {};
Predictor m_predictor {};
Optional<u8> m_alpha_channel_index {};
};
}