beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-24 08:30:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

headless-browser: Replace the log-slowest-tests flag with a verbose flag

Browse source 
Instead of adding a separate flag for each thing we want to log, let's
just have a verbosity flag. We can add verbosity levels later if needed.
This commit is contained in:
Timothy Flynn 2024-11-11 07:54:51 -05:00 committed by Andreas Kling
parent 0ff91a5273
commit d2306efaea
Notes: github-actions[bot] 2024-11-11 15:55:51 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d2306efaea8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2283
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
UI/Headless/Application.cpp
View file

@ -44,8 +44,8 @@ void Application::create_platform_arguments(Core::ArgsParser& args_parser)
args_parser.add_option(resources_folder, "Path of the base resources folder (defaults to /res)", "resources", 'r', "resources-root-path");
args_parser.add_option(is_layout_test_mode, "Enable layout test mode", "layout-test-mode");
args_parser.add_option(rebaseline, "Rebaseline any executed layout or text tests", "rebaseline");
args_parser.add_option(log_slowest_tests, "Log the tests with the slowest run times", "log-slowest-tests");
args_parser.add_option(per_test_timeout_in_seconds, "Per-test timeout (default: 30)", "per-test-timeout", 't', "seconds");
args_parser.add_option(verbose, "Log extra information about test results", "verbose", 'v');
}
void Application::create_platform_options(WebView::ChromeOptions& chrome_options, WebView::WebContentOptions& web_content_options)

2
UI/Headless/Application.h
View file

@ -64,7 +64,7 @@ public:
ByteString test_glob;
bool test_dry_run { false };
bool rebaseline { false };
bool log_slowest_tests { false };
bool verbose { false };
int per_test_timeout_in_seconds { 30 };
private:

2
UI/Headless/Test.cpp
View file

@ -504,7 +504,7 @@ ErrorOr<void> run_tests(Core::AnonymousBuffer const& theme, Gfx::IntSize window_
for (auto const& non_passing_test : non_passing_tests)
outln("{}: {}", test_result_to_string(non_passing_test.result), non_passing_test.test.input_path);
if (app.log_slowest_tests) {
if (app.verbose) {
auto tests_to_print = min(10uz, tests.size());
outln("\nSlowest {} tests:", tests_to_print);