beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Do not clear VM's string cache in Heap's destructor

Browse source 
There is definitely a possibility I am misunderstanding the reason
behind it - but this does not appear neccessary. The VM owns both the
string cache and Heap. On destruction, the VM should clear out both
the heap and its string cache.
This commit is contained in:
Shannon Booth 2024-08-18 21:59:32 +12:00 committed by Andreas Kling
parent cf27eef583
commit d199bf60cf
Notes: github-actions[bot] 2024-11-13 10:09:36 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d199bf60cf9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2284
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Heap/Heap.cpp
View file

@ -43,8 +43,6 @@ Heap::Heap(VM& vm)
Heap::~Heap()
{
vm().string_cache().clear();
vm().byte_string_cache().clear();
collect_garbage(CollectionType::CollectEverything);
}