beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS/Bytecode: Allow assignment expression to write directly to locals

Browse source
This commit is contained in:
Andreas Kling 2024-05-14 13:15:14 +02:00
parent d22a06d671
commit ce7c925924
Notes: sideshowbarker 2024-07-17 01:55:29 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/ce7c925924
Pull-request: https://github.com/SerenityOS/serenity/pull/24324
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -642,7 +642,12 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> AssignmentExpression::g
return TRY(m_rhs->generate_bytecode(generator)).value();
}());
auto dst = choose_dst(generator, preferred_dst);
// OPTIMIZATION: If LHS is a local, we can write the result directly into it.
auto dst = [&] {
if (lhs.operand().is_local())
return lhs;
return choose_dst(generator, preferred_dst);
}();
switch (m_op) {
case AssignmentOp::AdditionAssignment: