beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Ladybird: Remove unused LoadType parameter from Tab::navigate

Browse source 
The only non-default use of this parameter was removed in 980e7164fe.
This commit is contained in:
Timothy Flynn 2023-08-13 14:35:49 -04:00 committed by Sam Atkins
parent 340230f6bf
commit ccf2597bd3
Notes: sideshowbarker 2024-07-17 08:27:05 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/ccf2597bd3
Pull-request: https://github.com/SerenityOS/serenity/pull/20561
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Ladybird/Qt/Tab.cpp
View file

@ -517,14 +517,13 @@ void Tab::focus_location_editor()
m_location_edit->selectAll();
}
void Tab::navigate(QString url_qstring, LoadType load_type)
void Tab::navigate(QString url_qstring)
{
auto url_string = ak_deprecated_string_from_qstring(url_qstring);
if (url_string.starts_with('/'))
url_string = DeprecatedString::formatted("file://{}", url_string);
else if (URL url = url_string; !url.is_valid())
url_string = DeprecatedString::formatted("https://{}", url_string);
m_is_history_navigation = (load_type == LoadType::HistoryNavigation);
view().load(url_string);
}

6
Ladybird/Qt/Tab.h
View file

@ -32,11 +32,7 @@ public:
WebContentView& view() { return *m_view; }
enum class LoadType {
Normal,
HistoryNavigation,
};
void navigate(QString, LoadType = LoadType::Normal);
void navigate(QString);
void back();
void forward();
void reload();