beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWasm: Avoid pointless vector copies in Validator::Context

Browse source 
These vector copies accounted for more than 50% of the current runtime
of the validator on a large wasm file, this commit makes them
copy-on-write to avoid the copies where possible, gaining nearly a 50%
speedup.
This commit is contained in:
Ali Mohammad Pur 2024-03-11 16:54:37 +01:00 committed by Ali Mohammad Pur
parent cefe177a56
commit cced555879
Notes: sideshowbarker 2024-07-17 08:27:05 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/cced555879
Pull-request: https://github.com/SerenityOS/serenity/pull/23550
2 changed files with 17 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp
View file

@ -38,7 +38,8 @@ ErrorOr<void, ValidationError> Validator::validate(Module& module)
m_context = {}; m_context = {};
module.for_each_section_of_type<TypeSection>([this](TypeSection const& section) { module.for_each_section_of_type<TypeSection>([this](TypeSection const& section) {
m_context.types = section.types(); for (auto& type : section.types())
m_context.types.append(type);
}); });
module.for_each_section_of_type<ImportSection>([&](ImportSection const& section) { module.for_each_section_of_type<ImportSection>([&](ImportSection const& section) {
@ -90,23 +91,23 @@ ErrorOr<void, ValidationError> Validator::validate(Module& module)
module.for_each_section_of_type<TableSection>([this](TableSection const& section) { module.for_each_section_of_type<TableSection>([this](TableSection const& section) {
m_context.tables.ensure_capacity(m_context.tables.size() + section.tables().size()); m_context.tables.ensure_capacity(m_context.tables.size() + section.tables().size());
for (auto& table : section.tables()) for (auto& table : section.tables())
m_context.tables.unchecked_append(table.type()); m_context.tables.append(table.type());
}); });
module.for_each_section_of_type<MemorySection>([this](MemorySection const& section) { module.for_each_section_of_type<MemorySection>([this](MemorySection const& section) {
m_context.memories.ensure_capacity(m_context.memories.size() + section.memories().size()); m_context.memories.ensure_capacity(m_context.memories.size() + section.memories().size());
for (auto& memory : section.memories()) for (auto& memory : section.memories())
m_context.memories.unchecked_append(memory.type()); m_context.memories.append(memory.type());
}); });
module.for_each_section_of_type<GlobalSection>([this](GlobalSection const& section) { module.for_each_section_of_type<GlobalSection>([this](GlobalSection const& section) {
m_context.globals.ensure_capacity(m_context.globals.size() + section.entries().size()); m_context.globals.ensure_capacity(m_context.globals.size() + section.entries().size());
for (auto& global : section.entries()) for (auto& global : section.entries())
m_context.globals.unchecked_append(global.type()); m_context.globals.append(global.type());
}); });
module.for_each_section_of_type<ElementSection>([this](ElementSection const& section) { module.for_each_section_of_type<ElementSection>([this](ElementSection const& section) {
m_context.elements.ensure_capacity(section.segments().size()); m_context.elements.ensure_capacity(section.segments().size());
for (auto& segment : section.segments()) for (auto& segment : section.segments())
m_context.elements.unchecked_append(segment.type); m_context.elements.append(segment.type);
}); });
module.for_each_section_of_type<DataSection>([this](DataSection const& section) { module.for_each_section_of_type<DataSection>([this](DataSection const& section) {
m_context.datas.resize(section.data().size()); m_context.datas.resize(section.data().size());

21
Userland/Libraries/LibWasm/AbstractMachine/Validator.h
View file

@ -6,6 +6,7 @@
#pragma once #pragma once
#include <AK/COWVector.h>
#include <AK/Debug.h> #include <AK/Debug.h>
#include <AK/HashTable.h> #include <AK/HashTable.h>
#include <AK/SourceLocation.h> #include <AK/SourceLocation.h>
@ -17,15 +18,15 @@
namespace Wasm { namespace Wasm {
struct Context { struct Context {
Vector<FunctionType> types; COWVector<FunctionType> types;
Vector<FunctionType> functions; COWVector<FunctionType> functions;
Vector<TableType> tables; COWVector<TableType> tables;
Vector<MemoryType> memories; COWVector<MemoryType> memories;
Vector<GlobalType> globals; COWVector<GlobalType> globals;
Vector<ValueType> elements; COWVector<ValueType> elements;
Vector<bool> datas; COWVector<bool> datas;
Vector<ValueType> locals; COWVector<ValueType> locals;
Vector<ResultType> labels; COWVector<ResultType> labels;
Optional<ResultType> return_; Optional<ResultType> return_;
AK::HashTable<FunctionIndex> references; AK::HashTable<FunctionIndex> references;
size_t imported_function_count { 0 }; size_t imported_function_count { 0 };
@ -345,7 +346,7 @@ private:
Vector<ChildScopeKind> m_entered_scopes; Vector<ChildScopeKind> m_entered_scopes;
Vector<BlockDetails> m_block_details; Vector<BlockDetails> m_block_details;
Vector<FunctionType> m_entered_blocks; Vector<FunctionType> m_entered_blocks;
Vector<GlobalType> m_globals_without_internal_globals; COWVector<GlobalType> m_globals_without_internal_globals;
}; };
} }