beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Move StringImpl::operator== implementation into StringImpl

Browse source
This commit is contained in:
Nico Weber 2020-10-05 11:15:49 -04:00 committed by Andreas Kling
parent ee9c18c118
commit cc765e14ca
Notes: sideshowbarker 2024-07-19 02:02:14 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/cc765e14caf
Pull-request: https://github.com/SerenityOS/serenity/pull/3693
Reviewed-by: https://github.com/awesomekling
3 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
AK/String.cpp
View file

@ -60,10 +60,7 @@ bool String::operator==(const String& other) const
if (!other.m_impl)
return false;
if (length() != other.length())
return false;
return !memcmp(characters(), other.characters(), length());
return *m_impl == *other.m_impl;
}
bool String::operator==(const StringView& other) const

7
AK/StringImpl.h
View file

@ -70,6 +70,13 @@ public:
return characters()[i];
}
bool operator==(const StringImpl& other) const
{
if (length() != other.length())
return false;
return !__builtin_memcmp(characters(), other.characters(), length());
}
unsigned hash() const
{
if (!m_has_hash)

5
Libraries/LibJS/Runtime/StringOrSymbol.h
View file

@ -30,7 +30,6 @@
#include <LibJS/Runtime/PrimitiveString.h>
#include <LibJS/Runtime/Symbol.h>
#include <LibJS/Runtime/Value.h>
#include <string.h>
namespace JS {
@ -132,9 +131,7 @@ public:
return false;
auto* this_impl = static_cast<const StringImpl*>(m_ptr);
auto* other_impl = static_cast<const StringImpl*>(other.m_ptr);
if (this_impl->length() != other_impl->length())
return false;
return !memcmp(this_impl->characters(), other_impl->characters(), this_impl->length());
return *this_impl == *other_impl;
}
if (is_symbol())
return other.is_symbol() && as_symbol() == other.as_symbol();