beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

GMLCompiler: Escape compiled strings

Browse source 
We don't want a newline to cause havoc.
This commit is contained in:
kleines Filmröllchen 2023-05-26 12:40:22 +02:00 committed by Andrew Kaster
parent 33bd078052
commit cc6b9d5873
Notes: sideshowbarker 2024-07-17 08:27:05 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/cc6b9d5873
Pull-request: https://github.com/SerenityOS/serenity/pull/20523
Reviewed-by: https://github.com/ADKaster
1 changed files with 28 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
Meta/Lagom/Tools/CodeGenerators/GMLCompiler/main.cpp
View file

@ -128,13 +128,39 @@ static char const footer[] = R"~~~(
}
)~~~";
static ErrorOr<String> escape_string(JsonValue to_escape)
{
auto string = TRY(String::from_deprecated_string(to_escape.as_string()));
// All C++ simple escape sequences; see https://en.cppreference.com/w/cpp/language/escape
// Other commonly-escaped characters are hard-to-type Unicode and therefore fine to include verbatim in UTF-8 coded strings.
static HashMap<StringView, StringView> escape_sequences = {
{ "\0"sv, "\\0"sv },
{ "\'"sv, "\\'"sv },
{ "\""sv, "\\\""sv },
{ "\\"sv, "\\\\"sv },
{ "\a"sv, "\\a"sv },
{ "\b"sv, "\\b"sv },
{ "\f"sv, "\\f"sv },
{ "\n"sv, "\\n"sv },
{ "\r"sv, "\\r"sv },
{ "\t"sv, "\\t"sv },
{ "\v"sv, "\\v"sv },
};
for (auto const& entries : escape_sequences)
string = TRY(string.replace(entries.key, entries.value, ReplaceMode::All));
return string;
}
// FIXME: In case of error, propagate the precise array+property that triggered the error.
static ErrorOr<String> generate_initializer_for(Optional<StringView> property_name, JsonValue value)
{
if (value.is_string()) {
if (property_name.has_value() && takes_deprecated_string(*property_name))
return String::formatted(R"~~~("{}"sv)~~~", value.as_string());
return String::formatted(R"~~~("{}"_string)~~~", value.as_string());
return String::formatted(R"~~~("{}"sv)~~~", TRY(escape_string(value)));
return String::formatted(R"~~~("{}"_string)~~~", TRY(escape_string(value)));
}
// No need to handle the smaller integer types separately.
if (value.is_integer<i64>())