beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Rename the local variable in the TRY() macro to avoid name clashes

Browse source 
"result" is a tad bit too generic to provide a clash-free experience -
we found instances in LibJS where this breaks already. Essentially this
doesn't work:

    auto foo = TRY(bar(result));

Because it expands to the following within the TRY() scope:

    {
        auto result = bar(result);
        ...
    }

And that of course fails:

    error: use of ‘result’ before deduction of ‘auto’

The simple solution here is to use a name that is much less likely to
clash with anything used in the expression ("_temporary_result"). :^)
This commit is contained in:
Linus Groh 2021-09-15 22:57:05 +01:00
parent e5fde795e0
commit cbdd069279
Notes: sideshowbarker 2024-07-18 03:54:42 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/cbdd0692792
Pull-request: https://github.com/SerenityOS/serenity/pull/10046
Reviewed-by: https://github.com/IdanHo
Reviewed-by: https://github.com/awesomekling
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
AK/Try.h
View file

@ -9,10 +9,10 @@
// NOTE: This macro works with any result type that has the expected APIs.
// It's designed with AK::Result and Kernel::KResult in mind.
#define TRY(expression) \
({ \
auto result = (expression); \
if (result.is_error()) \
return result.release_error(); \
result.release_value(); \
#define TRY(expression) \
({ \
auto _temporary_result = (expression); \
if (_temporary_result.is_error()) \
return _temporary_result.release_error(); \
_temporary_result.release_value(); \
})