beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS+js: Add a debug option (js -g) to GC after every allocation

Browse source 
This is very useful for discovering collector bugs.
This commit is contained in:
Andreas Kling 2020-03-16 19:18:46 +01:00
parent ab404a2f88
commit cb2e7d1c5f
Notes: sideshowbarker 2024-07-19 08:16:27 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/cb2e7d1c5f7
3 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Heap/Heap.cpp
View file

@ -49,6 +49,9 @@ Heap::~Heap()
Cell* Heap::allocate_cell(size_t size)
{
if (should_collect_on_every_allocation())
collect_garbage();
for (auto& block : m_blocks) {
if (size > block->cell_size())
continue;

5
Libraries/LibJS/Heap/Heap.h
View file

@ -55,6 +55,9 @@ public:
Interpreter& interpreter() { return m_interpreter; }
bool should_collect_on_every_allocation() const { return m_should_collect_on_every_allocation; }
void set_should_collect_on_every_allocation(bool b) { m_should_collect_on_every_allocation = b; }
private:
Cell* allocate_cell(size_t);
@ -65,6 +68,8 @@ private:
Cell* cell_from_possible_pointer(FlatPtr);
bool m_should_collect_on_every_allocation { false };
Interpreter& m_interpreter;
Vector<NonnullOwnPtr<HeapBlock>> m_blocks;
};

3
Userland/js.cpp
View file

@ -41,10 +41,12 @@
int main(int argc, char** argv)
{
bool dump_ast = false;
bool gc_on_every_allocation = false;
const char* script_path = nullptr;
Core::ArgsParser args_parser;
args_parser.add_option(dump_ast, "Dump the AST", "ast-dump", 'A');
args_parser.add_option(gc_on_every_allocation, "GC on every allocation", "gc-on-every-allocation", 'g');
args_parser.add_positional_argument(script_path, "Path to script file", "script");
args_parser.parse(argc, argv);
@ -56,6 +58,7 @@ int main(int argc, char** argv)
auto file_contents = file->read_all();
JS::Interpreter interpreter;
interpreter.heap().set_should_collect_on_every_allocation(gc_on_every_allocation);
auto program = JS::Parser(JS::Lexer(file_contents)).parse_program();