From c92d9cce42037b39e2a982ece8cdec1cb45d5d71 Mon Sep 17 00:00:00 2001 From: pheonixfirewingz Date: Wed, 9 Oct 2024 22:29:30 +0100 Subject: [PATCH] Toolchain: Rewrite BuildVcpkg.sh in python Co-Authored-By: Andrew Kaster --- Meta/ladybird.sh | 2 +- Toolchain/BuildVcpkg.py | 47 ++++++++++++++++++++++++++++++++++++++++ Toolchain/BuildVcpkg.sh | 48 +---------------------------------------- 3 files changed, 49 insertions(+), 48 deletions(-) create mode 100755 Toolchain/BuildVcpkg.py diff --git a/Meta/ladybird.sh b/Meta/ladybird.sh index e79c025e20f..c989ce3f4ba 100755 --- a/Meta/ladybird.sh +++ b/Meta/ladybird.sh @@ -137,7 +137,7 @@ delete_target() { } build_vcpkg() { - ( cd "$LADYBIRD_SOURCE_DIR/Toolchain" && ./BuildVcpkg.sh ) + ( cd "$LADYBIRD_SOURCE_DIR/Toolchain" && python3 ./BuildVcpkg.py ) } ensure_toolchain() { diff --git a/Toolchain/BuildVcpkg.py b/Toolchain/BuildVcpkg.py new file mode 100755 index 00000000000..6c435674050 --- /dev/null +++ b/Toolchain/BuildVcpkg.py @@ -0,0 +1,47 @@ +#!/usr/bin/env python3 + +import os +import subprocess +import pathlib +import sys +import shutil + + +def main() -> int: + script_dir = pathlib.Path(__file__).parent.resolve() + + git_repo = "https://github.com/microsoft/vcpkg.git" + git_rev = "2960d7d80e8d09c84ae8abf15c12196c2ca7d39a" # 2024.09.30 + + tarball_dir = script_dir / "Tarballs" + tarball_dir.mkdir(parents=True, exist_ok=True) + vcpkg_checkout = tarball_dir / "vcpkg" + + if not vcpkg_checkout.is_dir(): + subprocess.check_call(args=["git", "clone", git_repo], cwd=tarball_dir) + else: + bootstrapped_vcpkg_version = subprocess.check_output( + ["git", "-C", vcpkg_checkout, "rev-parse", "HEAD"]).strip().decode() + + if bootstrapped_vcpkg_version == git_rev: + return 0 + + print(f"Building vcpkg@{git_rev}") + + subprocess.check_call(args=["git", "fetch", "origin"], cwd=vcpkg_checkout) + subprocess.check_call(args=["git", "checkout", git_rev], cwd=vcpkg_checkout) + + bootstrap_script = "bootstrap-vcpkg.bat" if os.name == 'nt' else "bootstrap-vcpkg.sh" + subprocess.check_call(args=[vcpkg_checkout / bootstrap_script, "-disableMetrics"], cwd=vcpkg_checkout, shell=True) + + install_dir = script_dir / "Local" / "vcpkg" / "bin" + install_dir.mkdir(parents=True, exist_ok=True) + + vcpkg_name = "vcpkg.exe" if os.name == 'nt' else "vcpkg" + shutil.copy(vcpkg_checkout / vcpkg_name, install_dir / vcpkg_name) + + return 0 + + +if __name__ == "__main__": + sys.exit(main()) diff --git a/Toolchain/BuildVcpkg.sh b/Toolchain/BuildVcpkg.sh index acd8b4772d1..7213b35e8d3 100755 --- a/Toolchain/BuildVcpkg.sh +++ b/Toolchain/BuildVcpkg.sh @@ -1,49 +1,3 @@ #!/usr/bin/env bash -# This script builds the vcpkg dependency management system -set -e - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" - -# shellcheck source=/dev/null -. "${DIR}/../Meta/shell_include.sh" - -# FIXME: Make the test262-runner CI use a non-root user -ci=0 -if [[ "$1" == "--ci" ]]; then - echo "Running in CI mode, will not check for root user" - ci=1 - shift -fi - -if [ "$ci" -eq 0 ]; then - exit_if_running_as_root "Do not run BuildVcpkg.sh as root, parts of your Toolchain directory will become root-owned" -fi - -GIT_REPO="https://github.com/microsoft/vcpkg.git" -GIT_REV="2960d7d80e8d09c84ae8abf15c12196c2ca7d39a" # 2024.09.30 -PREFIX_DIR="$DIR/Local/vcpkg" - -mkdir -p "$DIR/Tarballs" -pushd "$DIR/Tarballs" - if [[ ! -d vcpkg ]]; then - git clone "${GIT_REPO}" - else - bootstrapped_vcpkg_version=$(git -C vcpkg rev-parse HEAD) - - if [[ "${bootstrapped_vcpkg_version}" == "${GIT_REV}" ]]; then - exit 0 - fi - fi - - echo "Building vcpkg" - - cd vcpkg - git fetch origin - git checkout $GIT_REV - - ./bootstrap-vcpkg.sh -disableMetrics - - mkdir -p "$PREFIX_DIR/bin" - cp vcpkg "$PREFIX_DIR/bin" -popd +python3 ./Toolchain/BuildVcpkg.py