beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Skip documents of decoded SVGs while processing HTML event loop

Browse source 
None of HTML event loop processing steps are relevant for decoded SVGs,
so we can simply skip them while collecting documents for processing.
This commit is contained in:
Aliaksandr Kalenik 2024-08-18 21:25:04 +02:00 committed by Andreas Kling
parent 00f03f3e90
commit c87214d79c
Notes: github-actions[bot] 2024-08-19 07:05:54 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c87214d79cf
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1115
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Layout/expected/svg/inline-svg-with-zero-intrinsic-size-and-no-viewbox.txt
View file

@ -6,12 +6,6 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
" "
frag 2 from SVGSVGBox start: 0, length: 0, rect: [16,21 0x0] baseline: 0
ImageBox <img> at (8,21) content-size 0x0 children: not-inline
(SVG-as-image isolated context)
Viewport <#document> at (0,0) content-size 0x0 [BFC] children: inline
SVGSVGBox <svg> at (0,0) content-size 0x0 [SVG] children: inline
TextNode <#text>
SVGGeometryBox <rect> at (0,0) content-size 1x1 children: not-inline
TextNode <#text>
TextNode <#text>
SVGSVGBox <svg> at (16,21) content-size 0x0 [SVG] children: inline
TextNode <#text>

2
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -495,6 +495,8 @@ Vector<JS::Handle<DOM::Document>> EventLoop::documents_in_this_event_loop() cons
Vector<JS::Handle<DOM::Document>> documents;
for (auto& document : m_documents) {
VERIFY(document);
if (document->is_decoded_svg())
continue;
documents.append(JS::make_handle(*document));
}
return documents;