beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Return a constant reference from JsonValue::as_string

Browse source 
Rather than making a copy of the held string, this returns a reference
so that expressions like the following:

    do_something(json.as_string().view());

are not disallowed once `ByteString::view() &&` is deleted.
This commit is contained in:
Timothy Flynn 2024-04-03 21:28:20 -04:00 committed by Andreas Kling
parent 6d38d55fc8
commit c7ea710b55
Notes: sideshowbarker 2024-07-17 09:47:09 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/c7ea710b55
Pull-request: https://github.com/SerenityOS/serenity/pull/23830
Reviewed-by: https://github.com/shannonbooth ✅
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/JsonValue.h
View file

@ -128,7 +128,7 @@ public:
return m_value.get<bool>();
}
ByteString as_string() const
ByteString const& as_string() const
{
return m_value.get<ByteString>();
}