From c61de8e4bee2135c83c1e515dc5444f3ae41dcd7 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sun, 25 Apr 2021 22:40:21 +0200 Subject: [PATCH] LibJS: Use Object::get_own_properties() for getOwnPropertyNames() --- .../Libraries/LibJS/Runtime/ObjectConstructor.cpp | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp b/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp index 55cecc5e27a..5c1caabfa24 100644 --- a/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp +++ b/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp @@ -71,16 +71,7 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::get_own_property_names) auto* object = vm.argument(0).to_object(global_object); if (vm.exception()) return {}; - auto* result = Array::create(global_object); - for (auto& entry : object->indexed_properties()) - result->indexed_properties().append(js_string(vm, String::number(entry.index()))); - for (auto& it : object->shape().property_table_ordered()) { - if (!it.key.is_string()) - continue; - result->indexed_properties().append(js_string(vm, it.key.as_string())); - } - - return result; + return Array::create_from(global_object, object->get_own_properties(PropertyKind::Key, false, GetOwnPropertyReturnType::StringOnly)); } JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::get_prototype_of)