beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Return empty string if object element data URL is invalid

Browse source
This commit is contained in:
Tim Ledbetter 2024-08-15 00:08:54 +01:00 committed by Andreas Kling
parent 4f7a4d9c57
commit c61262684b
Notes: github-actions[bot] 2024-08-15 07:45:28 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c61262684b5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1080
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/invalid-url-attribute-values.txt
View file

@ -1 +1,2 @@
img.currentSrc default value: ''
object.data default value: ''

1
Tests/LibWeb/Text/input/HTML/invalid-url-attribute-values.html
View file

@ -4,6 +4,7 @@
test(() => {
const elementList = [
{ "img": "currentSrc" },
{ "object": "data" },
];
for (const elementDescriptor of elementList) {
[elementName, propertyName] = Object.entries(elementDescriptor)[0];

7
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -77,8 +77,11 @@ void HTMLObjectElement::form_associated_element_was_removed(DOM::Node*)
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-object-data
String HTMLObjectElement::data() const
{
auto data = get_attribute_value(HTML::AttributeNames::data);
return MUST(document().parse_url(data).to_string());
auto data = get_attribute(HTML::AttributeNames::data);
if (!data.has_value())
return {};
return MUST(document().parse_url(*data).to_string());
}
JS::GCPtr<Layout::Node> HTMLObjectElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style)