beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Allow intrinsic size keywords for min-height and max-height

Browse source
This commit is contained in:
Andreas Kling 2024-10-27 18:28:10 +01:00 committed by Andreas Kling
parent 5a9d538acc
commit c5a54f1166
Notes: github-actions[bot] 2024-10-27 20:03:41 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c5a54f1166e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2007
5 changed files with 23 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/max-height-computed.txt
View file

@ -6,12 +6,12 @@ Rerun
Found 12 tests Found 12 tests
4 Pass 6 Pass
8 Fail 6 Fail
Details Details
Result Test Name MessagePass Property max-height value 'none' Result Test Name MessagePass Property max-height value 'none'
Fail Property max-height value 'min-content' assert_true: 'min-content' is a supported value for max-height. expected true got false Pass Property max-height value 'min-content'
Fail Property max-height value 'max-content' assert_true: 'max-content' is a supported value for max-height. expected true got false Pass Property max-height value 'max-content'
Pass Property max-height value '10px' Pass Property max-height value '10px'
Pass Property max-height value '20%' Pass Property max-height value '20%'
Pass Property max-height value 'calc(10% + 40px)' Pass Property max-height value 'calc(10% + 40px)'

8
Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/max-height-valid.txt
View file

@ -6,12 +6,12 @@ Rerun
Found 10 tests Found 10 tests
4 Pass 6 Pass
6 Fail 4 Fail
Details Details
Result Test Name MessagePass e.style['max-height'] = "none" should set the property value Result Test Name MessagePass e.style['max-height'] = "none" should set the property value
Fail e.style['max-height'] = "min-content" should set the property value assert_not_equals: property should be set got disallowed value "" Pass e.style['max-height'] = "min-content" should set the property value
Fail e.style['max-height'] = "max-content" should set the property value assert_not_equals: property should be set got disallowed value "" Pass e.style['max-height'] = "max-content" should set the property value
Pass e.style['max-height'] = "0" should set the property value Pass e.style['max-height'] = "0" should set the property value
Pass e.style['max-height'] = "10%" should set the property value Pass e.style['max-height'] = "10%" should set the property value
Pass e.style['max-height'] = "0.5em" should set the property value Pass e.style['max-height'] = "0.5em" should set the property value

8
Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-height-computed.txt
View file

@ -6,11 +6,11 @@ Rerun
Found 11 tests Found 11 tests
3 Pass 5 Pass
8 Fail 6 Fail
Details Details
Result Test Name MessageFail Property min-height value 'min-content' assert_true: 'min-content' is a supported value for min-height. expected true got false Result Test Name MessagePass Property min-height value 'min-content'
Fail Property min-height value 'max-content' assert_true: 'max-content' is a supported value for min-height. expected true got false Pass Property min-height value 'max-content'
Pass Property min-height value '10px' Pass Property min-height value '10px'
Pass Property min-height value '20%' Pass Property min-height value '20%'
Pass Property min-height value 'calc(10% + 40px)' Pass Property min-height value 'calc(10% + 40px)'

8
Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-height-valid.txt
View file

@ -6,12 +6,12 @@ Rerun
Found 10 tests Found 10 tests
4 Pass 6 Pass
6 Fail 4 Fail
Details Details
Result Test Name MessagePass e.style['min-height'] = "auto" should set the property value Result Test Name MessagePass e.style['min-height'] = "auto" should set the property value
Fail e.style['min-height'] = "min-content" should set the property value assert_not_equals: property should be set got disallowed value "" Pass e.style['min-height'] = "min-content" should set the property value
Fail e.style['min-height'] = "max-content" should set the property value assert_not_equals: property should be set got disallowed value "" Pass e.style['min-height'] = "max-content" should set the property value
Pass e.style['min-height'] = "0" should set the property value Pass e.style['min-height'] = "0" should set the property value
Pass e.style['min-height'] = "10%" should set the property value Pass e.style['min-height'] = "10%" should set the property value
Pass e.style['min-height'] = "0.5em" should set the property value Pass e.style['min-height'] = "0.5em" should set the property value

8
Userland/Libraries/LibWeb/CSS/Properties.json
View file

@ -1905,6 +1905,9 @@
"percentage [0,∞]" "percentage [0,∞]"
], ],
"valid-identifiers": [ "valid-identifiers": [
"fit-content",
"max-content",
"min-content",
"none" "none"
], ],
"percentages-resolve-to": "length", "percentages-resolve-to": "length",
@ -1947,7 +1950,10 @@
"percentage [0,∞]" "percentage [0,∞]"
], ],
"valid-identifiers": [ "valid-identifiers": [
"auto" "auto",
"fit-content",
"max-content",
"min-content"
], ],
"percentages-resolve-to": "length", "percentages-resolve-to": "length",
"quirks": [ "quirks": [