beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Ladybird/Qt: Ensure the Inspector widget is deleted before the WebView

Browse source 
According to Qt documentation, destruction of a QObject's children may
happen in any order. In our case, the Tab's WebContentView is deleted
before its InspectorWidget. The InspectorWidget performs cleanup on that
WebContentView in its destructor; this causes use-after-free since it
has already been destroyed.

From reading Qt threads, if a particular destruction order is required,
it is okay to enforce that order with manual `delete`s. This patch does
so with the InspectorWidget to ensure it is deleted before the
WebContentView. Qt's object ownership is okay with this - it will remove
the InspectorWidget from the Tab's children, preventing any double
deletion.
This commit is contained in:
Timothy Flynn 2023-12-29 09:05:05 -05:00 committed by Andrew Kaster
parent a2bd19fdac
commit c4e2c725ec
Notes: sideshowbarker 2024-07-17 10:08:28 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/c4e2c725ec
Pull-request: https://github.com/SerenityOS/serenity/pull/22490
Issue: https://github.com/SerenityOS/serenity/issues/22279
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Ladybird/Qt/Tab.cpp
View file

@ -579,6 +579,10 @@ Tab::Tab(BrowserWindow* window, WebContentOptions const& web_content_options, St
Tab::~Tab()
{
close_sub_widgets();
// Delete the InspectorWidget explicitly to ensure it is deleted before the WebContentView. Otherwise, Qt
// can destroy these objects in any order, which may cause use-after-free in InspectorWidget's destructor.
delete m_inspector_widget;
}
void Tab::select_dropdown_add_item(QMenu* menu, Web::HTML::SelectItem const& item)