beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 15:10:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Update LegendBox and FieldSetBox to use GC namespace
Some checks are pending
CI / Lagom (false, FUZZ, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (false, NO_FUZZ, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (false, NO_FUZZ, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (true, NO_FUZZ, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (macos-14, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Fixes broken build.
This commit is contained in:
Aliaksandr Kalenik 2024-11-19 14:47:18 +01:00 committed by Alexander Kalenik
parent a820308a02
commit c47d19d05a
Notes: github-actions[bot] 2024-11-19 13:52:36 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c47d19d05a3
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2439
8 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLFieldSetElement.cpp
View file

@ -83,7 +83,7 @@ Layout::FieldSetBox* HTMLFieldSetElement::layout_node()
return static_cast<Layout::FieldSetBox*>(Node::layout_node());
}
JS::GCPtr<Layout::Node> HTMLFieldSetElement::create_layout_node(CSS::StyleProperties style)
GC::Ptr<Layout::Node> HTMLFieldSetElement::create_layout_node(CSS::StyleProperties style)
{
return heap().allocate<Layout::FieldSetBox>(document(), *this, style);
}

2
Libraries/LibWeb/HTML/HTMLFieldSetElement.h
View file

@ -42,7 +42,7 @@ public:
virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::group; }
virtual JS::GCPtr<Layout::Node> create_layout_node(CSS::StyleProperties) override;
virtual GC::Ptr<Layout::Node> create_layout_node(CSS::StyleProperties) override;
Layout::FieldSetBox* layout_node();
Layout::FieldSetBox const* layout_node() const;

2
Libraries/LibWeb/HTML/HTMLLegendElement.cpp
View file

@ -40,7 +40,7 @@ HTMLFormElement* HTMLLegendElement::form()
return nullptr;
}
JS::GCPtr<Layout::Node> HTMLLegendElement::create_layout_node(CSS::StyleProperties style)
GC::Ptr<Layout::Node> HTMLLegendElement::create_layout_node(CSS::StyleProperties style)
{
return heap().allocate<Layout::LegendBox>(document(), *this, move(style));
}

2
Libraries/LibWeb/HTML/HTMLLegendElement.h
View file

@ -20,7 +20,7 @@ public:
HTMLFormElement* form();
virtual JS::GCPtr<Layout::Node> create_layout_node(CSS::StyleProperties) override;
virtual GC::Ptr<Layout::Node> create_layout_node(CSS::StyleProperties) override;
Layout::LegendBox* layout_node();
Layout::LegendBox const* layout_node() const;

2
Libraries/LibWeb/Layout/FieldSetBox.cpp
View file

@ -10,7 +10,7 @@
namespace Web::Layout {
JS_DEFINE_ALLOCATOR(FieldSetBox);
GC_DEFINE_ALLOCATOR(FieldSetBox);
FieldSetBox::FieldSetBox(DOM::Document& document, DOM::Element& element, CSS::StyleProperties style)
: BlockContainer(document, &element, move(style))

5
Libraries/LibWeb/Layout/FieldSetBox.h
View file

@ -8,11 +8,12 @@
#include <LibWeb/Forward.h>
#include <LibWeb/Layout/BlockContainer.h>
namespace Web::Layout {
class FieldSetBox final : public BlockContainer {
JS_CELL(FieldSetBox, BlockContainer);
JS_DECLARE_ALLOCATOR(FieldSetBox);
GC_CELL(FieldSetBox, BlockContainer);
GC_DECLARE_ALLOCATOR(FieldSetBox);
public:
FieldSetBox(DOM::Document&, DOM::Element&, CSS::StyleProperties);

2
Libraries/LibWeb/Layout/LegendBox.cpp
View file

@ -8,7 +8,7 @@
namespace Web::Layout {
JS_DEFINE_ALLOCATOR(LegendBox);
GC_DEFINE_ALLOCATOR(LegendBox);
LegendBox::LegendBox(DOM::Document& document, DOM::Element& element, CSS::StyleProperties style)
: BlockContainer(document, &element, move(style))

4
Libraries/LibWeb/Layout/LegendBox.h
View file

@ -11,8 +11,8 @@
namespace Web::Layout {
class LegendBox final : public BlockContainer {
JS_CELL(LegendBox, BlockContainer);
JS_DECLARE_ALLOCATOR(LegendBox);
GC_CELL(LegendBox, BlockContainer);
GC_DECLARE_ALLOCATOR(LegendBox);
public:
LegendBox(DOM::Document&, DOM::Element&, CSS::StyleProperties);