beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Lagom: Add argument WORKING_DIRECTORY to lagom_test(...)

Browse source 
So far the working directory was set in some cases using
`set_tests_properties(...)`, but this requires to know which name is
picked by `lagom_test(...)` when calling `add_test(...)`.
In case of adding multiple test cases using a globbing pattern this
would require to duplicate code to construct the test name from the file
name.
This commit is contained in:
Simon Woertz 2021-11-21 21:18:27 +01:00 committed by Brian Gianforcaro
parent 7e04160b0b
commit c2df6b597a
Notes: sideshowbarker 2024-07-17 22:45:47 +09:00 
Author: https://github.com/swoertz
Commit: https://github.com/SerenityOS/serenity/commit/c2df6b597a1
Pull-request: https://github.com/SerenityOS/serenity/pull/11016
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Meta/Lagom/CMakeLists.txt
View file

@ -204,7 +204,7 @@ function(lagom_lib library fs_name)
endfunction()
function(lagom_test source)
cmake_parse_arguments(LAGOM_TEST "" "" "LIBS" ${ARGN})
cmake_parse_arguments(LAGOM_TEST "" "WORKING_DIRECTORY" "LIBS" ${ARGN})
get_filename_component(name ${source} NAME_WE)
add_executable(${name}_lagom ${source})
set_target_properties(${name}_lagom PROPERTIES OUTPUT_NAME ${name})
@ -212,6 +212,7 @@ function(lagom_test source)
add_test(
NAME ${name}
COMMAND ${name}_lagom
WORKING_DIRECTORY ${LAGOM_TEST_WORKING_DIRECTORY}
)
endfunction()
@ -500,13 +501,11 @@ if (BUILD_LAGOM)
# AK
file(GLOB AK_TEST_SOURCES CONFIGURE_DEPENDS "../../Tests/AK/*.cpp")
foreach(source ${AK_TEST_SOURCES})
lagom_test(${source})
lagom_test(${source} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/AK)
endforeach()
set_tests_properties(TestJSON PROPERTIES WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/AK)
# Core
lagom_test(../../Tests/LibCore/TestLibCoreIODevice.cpp)
set_tests_properties(TestLibCoreIODevice PROPERTIES WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/LibCore)
lagom_test(../../Tests/LibCore/TestLibCoreIODevice.cpp WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/LibCore)
# Crypto
file(GLOB LIBCRYPTO_TESTS CONFIGURE_DEPENDS "../../Tests/LibCrypto/*.cpp")
@ -544,8 +543,8 @@ if (BUILD_LAGOM)
# TLS
file(GLOB LIBTLS_TESTS CONFIGURE_DEPENDS "../../Tests/LibTLS/*.cpp")
foreach(source ${LIBTLS_TESTS})
lagom_test(${source} LIBS LagomTLS)
set_tests_properties(TestTLSHandshake PROPERTIES WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/LibTLS)
lagom_test(${source} LIBS LagomTLS
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/LibTLS)
endforeach()
# Unicode