beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Ladybird: The JS console widget should be a standalone window

Browse source 
...not part of the WebView. Its lifetime is managed by a QPointer.
This commit is contained in:
Andreas Kling 2022-10-02 11:17:11 +02:00 committed by Andrew Kaster
parent b2ba91123b
commit c2230d5fe8
Notes: sideshowbarker 2024-07-17 02:42:45 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/c2230d5fe8
Pull-request: https://github.com/SerenityOS/serenity/pull/16583
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/SimpleWebView.cpp
View file

@ -586,7 +586,7 @@ void SimpleWebView::did_get_js_console_messages(i32, Vector<String>, Vector<Stri
void SimpleWebView::ensure_js_console_widget()
{
if (!m_js_console_widget) {
m_js_console_widget = new QWidget(this);
m_js_console_widget = new QWidget;
m_js_console_widget->setWindowTitle("JS Console");
auto* layout = new QVBoxLayout(m_js_console_widget);
m_js_console_widget->setLayout(layout);