beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Use default constructor/destructor instead of declaring an empty one

Browse source 
Default implementations allow for more optimizations.
See: https://pvs-studio.com/en/docs/warnings/v832/
This commit is contained in:
Brian Gianforcaro 2021-09-15 23:20:31 -07:00 committed by Andreas Kling
parent 9fe43041f5
commit c192c303d2
Notes: sideshowbarker 2024-07-18 03:52:35 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/c192c303d22
Pull-request: https://github.com/SerenityOS/serenity/pull/10053
8 changed files with 7 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/CircularQueue.h
View file

@ -17,9 +17,7 @@ class CircularQueue {
friend CircularDuplexStream<Capacity>; friend CircularDuplexStream<Capacity>;
public: public:
CircularQueue() CircularQueue() = default;
{
}
~CircularQueue() ~CircularQueue()
{ {

4
AK/DistinctNumeric.h
View file

@ -52,9 +52,7 @@ class DistinctNumeric {
using Self = DistinctNumeric<T, X, Incr, Cmp, Bool, Flags, Shift, Arith>; using Self = DistinctNumeric<T, X, Incr, Cmp, Bool, Flags, Shift, Arith>;
public: public:
constexpr DistinctNumeric() constexpr DistinctNumeric() = default;
{
}
constexpr DistinctNumeric(T value) constexpr DistinctNumeric(T value)
: m_value { value } : m_value { value }

2
AK/FixedArray.h
View file

@ -15,7 +15,7 @@ namespace AK {
template<typename T> template<typename T>
class FixedArray { class FixedArray {
public: public:
FixedArray() { } FixedArray() = default;
explicit FixedArray(size_t size) explicit FixedArray(size_t size)
: m_size(size) : m_size(size)
{ {

4
AK/NonnullPtrVector.h
View file

@ -16,9 +16,7 @@ class NonnullPtrVector : public Vector<PtrType, inline_capacity> {
using Base = Vector<PtrType, inline_capacity>; using Base = Vector<PtrType, inline_capacity>;
public: public:
NonnullPtrVector() NonnullPtrVector() = default;
{
}
NonnullPtrVector(Vector<PtrType>&& other) NonnullPtrVector(Vector<PtrType>&& other)
: Base(static_cast<Base&&>(other)) : Base(static_cast<Base&&>(other))

2
AK/RedBlackTree.h
View file

@ -46,7 +46,7 @@ public:
protected: protected:
BaseRedBlackTree() = default; // These are protected to ensure no one instantiates the leaky base red black tree directly BaseRedBlackTree() = default; // These are protected to ensure no one instantiates the leaky base red black tree directly
virtual ~BaseRedBlackTree() {}; virtual ~BaseRedBlackTree() = default;
void rotate_left(Node* subtree_root) void rotate_left(Node* subtree_root)
{ {

3
AK/UUID.cpp
View file

@ -10,9 +10,6 @@
#include <AK/UUID.h> #include <AK/UUID.h>
namespace AK { namespace AK {
UUID::UUID()
{
}
UUID::UUID(Array<u8, 16> uuid_buffer) UUID::UUID(Array<u8, 16> uuid_buffer)
{ {

2
AK/UUID.h
View file

@ -15,7 +15,7 @@ namespace AK {
class UUID { class UUID {
public: public:
UUID(); UUID() = default;
UUID(Array<u8, 16> uuid_buffer); UUID(Array<u8, 16> uuid_buffer);
UUID(const StringView&); UUID(const StringView&);
~UUID() = default; ~UUID() = default;

2
AK/Variant.h
View file

@ -116,7 +116,7 @@ struct VariantConstructors {
internal_cast().set(t, VariantNoClearTag {}); internal_cast().set(t, VariantNoClearTag {});
} }
ALWAYS_INLINE VariantConstructors() { } ALWAYS_INLINE VariantConstructors() = default;
private: private:
[[nodiscard]] ALWAYS_INLINE Base& internal_cast() [[nodiscard]] ALWAYS_INLINE Base& internal_cast()