beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Add some missing [FIXME] IDL attributes

Browse source
This commit is contained in:
Tim Ledbetter 2024-05-21 16:40:32 +01:00 committed by Andreas Kling
parent 58bb5e1f7a
commit c0e504fbdd
Notes: sideshowbarker 2024-07-16 22:11:09 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/c0e504fbdd
Pull-request: https://github.com/SerenityOS/serenity/pull/24404
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -3194,7 +3194,7 @@ void @class_name@::initialize(JS::Realm& realm)
if (!interface.attributes.is_empty() || !interface.functions.is_empty() || interface.has_stringifier) {
generator.append(R"~~~(
static JS::ThrowCompletionOr<@fully_qualified_name@*> impl_from(JS::VM& vm)
[[maybe_unused]] static JS::ThrowCompletionOr<@fully_qualified_name@*> impl_from(JS::VM& vm)
{
auto this_value = vm.this_value();
JS::Object* this_object = nullptr;

2
Userland/Libraries/LibWeb/HTML/CanvasPattern.idl
View file

@ -2,5 +2,5 @@
[Exposed=(Window,Worker)]
interface CanvasPattern {
// opaque object
// FIXME: undefined setTransform(optional DOMMatrix2DInit transform = {});
[FIXME] undefined setTransform(optional DOMMatrix2DInit transform = {});
};

2
Userland/Libraries/LibWeb/HTML/HTMLElement.idl
View file

@ -28,7 +28,7 @@ interface HTMLElement : Element {
[LegacyNullToEmptyString, CEReactions] attribute DOMString innerText;
[LegacyNullToEmptyString, CEReactions] attribute DOMString outerText;
// FIXME: ElementInternals attachInternals();
[FIXME] ElementInternals attachInternals();
// The popover API
[FIXME] undefined showPopover();

2
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.idl
View file

@ -46,7 +46,7 @@ interface HTMLMediaElement : HTMLElement {
attribute double currentTime;
undefined fastSeek(double time);
readonly attribute unrestricted double duration;
// FIXME: object getStartDate();
[FIXME] object getStartDate();
readonly attribute boolean paused;
[FIXME] attribute double defaultPlaybackRate;
[FIXME] attribute double playbackRate;

2
Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.idl
View file

@ -34,7 +34,7 @@ interface HTMLTextAreaElement : HTMLElement {
readonly attribute NodeList labels;
// FIXME: undefined select();
[FIXME] undefined select();
attribute unsigned long selectionStart;
attribute unsigned long selectionEnd;
[FIXME] attribute DOMString selectionDirection;