beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Undo bogus Variant::downcast() rename

Browse source 
I accidentally renamed these to verify_cast() when doing the global
AK::downcast() rename.
This commit is contained in:
Andreas Kling 2021-06-26 21:22:49 +02:00
parent 337ad6d15c
commit beb43f673e
Notes: sideshowbarker 2024-07-18 11:28:21 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/beb43f673e8
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/Variant.h
View file

@ -319,7 +319,7 @@ public:
} }
template<typename... NewTs> template<typename... NewTs>
Variant<NewTs...> verify_cast() && Variant<NewTs...> downcast() &&
{ {
Variant<NewTs...> instance { Variant<NewTs...>::invalid_index, Detail::VariantConstructTag {} }; Variant<NewTs...> instance { Variant<NewTs...>::invalid_index, Detail::VariantConstructTag {} };
visit([&](auto& value) { visit([&](auto& value) {
@ -331,7 +331,7 @@ public:
} }
template<typename... NewTs> template<typename... NewTs>
Variant<NewTs...> verify_cast() & Variant<NewTs...> downcast() &
{ {
Variant<NewTs...> instance { Variant<NewTs...>::invalid_index, Detail::VariantConstructTag {} }; Variant<NewTs...> instance { Variant<NewTs...>::invalid_index, Detail::VariantConstructTag {} };
visit([&](const auto& value) { visit([&](const auto& value) {

4
Tests/AK/TestVariant.cpp
View file

@ -80,14 +80,14 @@ TEST_CASE(move_moves)
TEST_CASE(verify_cast) TEST_CASE(verify_cast)
{ {
Variant<i8, i16, i32, i64> one_integer_to_rule_them_all { static_cast<i32>(42) }; Variant<i8, i16, i32, i64> one_integer_to_rule_them_all { static_cast<i32>(42) };
auto fake_integer = one_integer_to_rule_them_all.verify_cast<i8, i32>(); auto fake_integer = one_integer_to_rule_them_all.downcast<i8, i32>();
EXPECT(fake_integer.has<i32>()); EXPECT(fake_integer.has<i32>());
EXPECT(one_integer_to_rule_them_all.has<i32>()); EXPECT(one_integer_to_rule_them_all.has<i32>());
EXPECT_EQ(fake_integer.get<i32>(), 42); EXPECT_EQ(fake_integer.get<i32>(), 42);
EXPECT_EQ(one_integer_to_rule_them_all.get<i32>(), 42); EXPECT_EQ(one_integer_to_rule_them_all.get<i32>(), 42);
fake_integer = static_cast<i8>(60); fake_integer = static_cast<i8>(60);
one_integer_to_rule_them_all = fake_integer.verify_cast<i8, i16>().verify_cast<i8, i32, float>().verify_cast<i8, i16, i32, i64>(); one_integer_to_rule_them_all = fake_integer.downcast<i8, i16>().downcast<i8, i32, float>().downcast<i8, i16, i32, i64>();
EXPECT(fake_integer.has<i8>()); EXPECT(fake_integer.has<i8>());
EXPECT(one_integer_to_rule_them_all.has<i8>()); EXPECT(one_integer_to_rule_them_all.has<i8>());
EXPECT_EQ(fake_integer.get<i8>(), 60); EXPECT_EQ(fake_integer.get<i8>(), 60);

2
Userland/Libraries/LibJS/Parser.cpp
View file

@ -1691,7 +1691,7 @@ NonnullRefPtr<VariableDeclaration> Parser::parse_variable_declaration(bool for_l
declarations.append(create_ast_node<VariableDeclarator>( declarations.append(create_ast_node<VariableDeclarator>(
{ m_state.current_token.filename(), rule_start.position(), position() }, { m_state.current_token.filename(), rule_start.position(), position() },
move(target).verify_cast<NonnullRefPtr<Identifier>, NonnullRefPtr<BindingPattern>>(), move(target).downcast<NonnullRefPtr<Identifier>, NonnullRefPtr<BindingPattern>>(),
move(init))); move(init)));
if (match(TokenType::Comma)) { if (match(TokenType::Comma)) {

2
Userland/Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp
View file

@ -397,7 +397,7 @@ Optional<InstantiationError> AbstractMachine::allocate_all_initial_phase(Module
module_instance.exports().append(ExportInstance { module_instance.exports().append(ExportInstance {
entry.name(), entry.name(),
move(address).verify_cast<FunctionAddress, TableAddress, MemoryAddress, GlobalAddress>(), move(address).downcast<FunctionAddress, TableAddress, MemoryAddress, GlobalAddress>(),
}); });
} }
}); });