beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Implement the HTMLTrackElement.kind attribute

Browse source 
This reflects the HTML `kind` attribute.
This commit is contained in:
Tim Ledbetter 2024-06-29 23:07:57 +01:00 committed by Andreas Kling
parent 0c4f257021
commit bdaa7f0e8e
Notes: sideshowbarker 2024-07-17 20:19:08 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/bdaa7f0e8e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/316
4 changed files with 39 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Tests/LibWeb/Text/expected/HTML/HTMLTrackElement-kind-attribute.txt Normal file
View file

@ -0,0 +1,7 @@
kind initial value: 'subtitles'
kind value after setting to "invalid": 'metadata'
kind value after setting to "captions": 'captions'
kind value after setting to null: 'metadata'
kind value after setting to "CHAPTERS": 'chapters'
kind value after setting to "": 'metadata'
kind value after calling removeAttribute: 'subtitles'

20
Tests/LibWeb/Text/input/HTML/HTMLTrackElement-kind-attribute.html Normal file
View file

@ -0,0 +1,20 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const trackElement = document.createElement("track");
println(`kind initial value: '${trackElement.kind}'`);
trackElement.kind = "invalid";
println(`kind value after setting to "invalid": '${trackElement.kind}'`);
trackElement.kind = "captions";
println(`kind value after setting to "captions": '${trackElement.kind}'`);
trackElement.kind = null;
println(`kind value after setting to null: '${trackElement.kind}'`);
trackElement.kind = "CHAPTERS";
println(`kind value after setting to "CHAPTERS": '${trackElement.kind}'`);
trackElement.kind = "";
println(`kind value after setting to "": '${trackElement.kind}'`);
trackElement.removeAttribute("kind");
println(`kind value after calling removeAttribute: '${trackElement.kind}'`);
});
</script>

1
Userland/Libraries/LibWeb/HTML/AttributeNames.h
View file

@ -94,6 +94,7 @@ namespace AttributeNames {
__ENUMERATE_HTML_ATTRIBUTE(is) \
__ENUMERATE_HTML_ATTRIBUTE(ismap) \
__ENUMERATE_HTML_ATTRIBUTE(itemscope) \
__ENUMERATE_HTML_ATTRIBUTE(kind) \
__ENUMERATE_HTML_ATTRIBUTE(label) \
__ENUMERATE_HTML_ATTRIBUTE(lang) \
__ENUMERATE_HTML_ATTRIBUTE(language) \

12
Userland/Libraries/LibWeb/HTML/HTMLTrackElement.idl
View file

@ -1,12 +1,22 @@
#import <HTML/HTMLElement.idl>
// https://html.spec.whatwg.org/multipage/media.html#attr-track-kind
[MissingValueDefault=subtitles, InvalidValueDefault=metadata]
enum TrackKindAttribute {
"subtitles",
"captions",
"descriptions",
"chapters",
"metadata"
};
// https://html.spec.whatwg.org/multipage/media.html#htmltrackelement
[Exposed=Window]
interface HTMLTrackElement : HTMLElement {
[HTMLConstructor] constructor();
[FIXME, CEReactions] attribute DOMString kind;
[CEReactions, Enumerated=TrackKindAttribute, Reflect] attribute DOMString kind;
[CEReactions, Reflect] attribute DOMString src;
[CEReactions, Reflect] attribute DOMString srclang;
[CEReactions, Reflect] attribute DOMString label;