beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Remove many unnecessary #includes in generated code

Browse source
This commit is contained in:
Andreas Kling 2022-09-04 17:12:39 +02:00
parent 39660a8680
commit bc74909308
Notes: sideshowbarker 2024-07-17 07:24:10 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/bc74909308
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
1 changed files with 0 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp
View file

@ -269,21 +269,6 @@ static String make_input_acceptable_cpp(String const& input)
return input.replace("-"sv, "_"sv, ReplaceMode::All);
}
static void generate_include_for_wrapper(auto& generator, auto& wrapper_name)
{
auto wrapper_generator = generator.fork();
wrapper_generator.set("wrapper_class", wrapper_name);
// FIXME: These may or may not exist, because REASONS.
wrapper_generator.append(R"~~~(
#if __has_include(<LibWeb/Bindings/@wrapper_class@.h>)
# include <LibWeb/Bindings/@wrapper_class@.h>
#endif
#if __has_include(<LibWeb/Bindings/@wrapper_class@Factory.h>)
# include <LibWeb/Bindings/@wrapper_class@Factory.h>
#endif
)~~~");
}
static void generate_include_for_iterator(auto& generator, auto& iterator_path, auto& iterator_name)
{
auto iterator_generator = generator.fork();
@ -294,15 +279,6 @@ static void generate_include_for_iterator(auto& generator, auto& iterator_path,
//#if __has_include(<LibWeb/@iterator_class.path@.h>)
# include <LibWeb/@iterator_class.path@.h>
//#endif
#if __has_include(<LibWeb/@iterator_class.path@Factory.h>)
# include <LibWeb/@iterator_class.path@Factory.h>
#endif
#if __has_include(<LibWeb/Bindings/@iterator_class.name@Wrapper.h>)
# include <LibWeb/Bindings/@iterator_class.name@Wrapper.h>
#endif
#if __has_include(<LibWeb/Bindings/@iterator_class.name@WrapperFactory.h>)
# include <LibWeb/Bindings/@iterator_class.name@WrapperFactory.h>
#endif
)~~~");
}
@ -353,9 +329,6 @@ static void emit_includes_for_all_imports(auto& interface, auto& generator, bool
auto iterator_path = String::formatted("{}Iterator", interface->fully_qualified_name.replace("::"sv, "/"sv, ReplaceMode::All));
generate_include_for_iterator(generator, iterator_path, iterator_name);
}
if (interface->wrapper_class != "Wrapper")
generate_include_for_wrapper(generator, interface->wrapper_class);
}
}
@ -1970,9 +1943,6 @@ void generate_constructor_implementation(IDL::Interface const& interface)
#include <LibJS/Runtime/ArrayBuffer.h>
#include <LibWeb/Bindings/@constructor_class@.h>
#include <LibWeb/Bindings/@prototype_class@.h>
#if __has_include(<LibWeb/Bindings/@wrapper_class@.h>)
#include <LibWeb/Bindings/@wrapper_class@.h>
#endif
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/HTML/Window.h>
#if __has_include(<LibWeb/Crypto/@name@.h>)
@ -2309,9 +2279,6 @@ void generate_prototype_implementation(IDL::Interface const& interface)
#include <LibJS/Runtime/TypedArray.h>
#include <LibJS/Runtime/Value.h>
#include <LibWeb/Bindings/@prototype_class@.h>
#if __has_include(<LibWeb/Bindings/@wrapper_class@.h>)
#include <LibWeb/Bindings/@wrapper_class@.h>
#endif
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/Bindings/LocationObject.h>
#include <LibWeb/DOM/Element.h>