From b87b1472e14816db5d6539351de8a4e2c0b166f6 Mon Sep 17 00:00:00 2001 From: Patryk Pilipczuk Date: Sun, 26 Feb 2023 19:45:53 +0100 Subject: [PATCH] HexEditor: Add BE decoding for UTF16String column in ValueInspector --- Userland/Applications/HexEditor/HexEditorWidget.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Applications/HexEditor/HexEditorWidget.cpp b/Userland/Applications/HexEditor/HexEditorWidget.cpp index 2869195bc40..4d4ef49bd1f 100644 --- a/Userland/Applications/HexEditor/HexEditorWidget.cpp +++ b/Userland/Applications/HexEditor/HexEditorWidget.cpp @@ -392,7 +392,9 @@ void HexEditorWidget::update_inspector_values(size_t position) // FIXME: Parse as other values like Timestamp etc - DeprecatedString utf16_string = TextCodec::decoder_for("utf-16le"sv)->to_utf8(StringView(selected_bytes.span())).release_value_but_fixme_should_propagate_errors().to_deprecated_string(); + auto decoder = TextCodec::decoder_for(m_value_inspector_little_endian ? "utf-16le"sv : "utf-16be"sv); + DeprecatedString utf16_string = decoder->to_utf8(StringView(selected_bytes.span())).release_value_but_fixme_should_propagate_errors().to_deprecated_string(); + value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::UTF16String, utf16_string); m_value_inspector->set_model(value_inspector_model);