beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-23 08:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Improve alias names in ResolveISOMonth

Browse source 
This is an editorial change in the Temporal spec.
See: https://github.com/tc39/proposal-temporal/commit/01d5fbe
This commit is contained in:
Moustafa Raafat 2022-10-16 12:41:17 +01:00 committed by Linus Groh
parent d758566996
commit b69ceae10c
Notes: sideshowbarker 2024-07-17 05:19:03 +09:00 
Author: https://github.com/moustafaraafat
Commit: https://github.com/SerenityOS/serenity/commit/b69ceae10c
Pull-request: https://github.com/SerenityOS/serenity/pull/15690
Reviewed-by: https://github.com/linusg ✅
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp
View file

@ -786,26 +786,26 @@ ThrowCompletionOr<double> resolve_iso_month(VM& vm, Object const& fields)
if (month_code_string[0] != 0x4D)
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidMonthCode);
// 9. Let numberPart be the substring of monthCode from 1.
auto number_part = month_code_string.substring(1);
// 9. Let monthCodeDigits be the substring of monthCode from 1.
auto month_code_digits = month_code_string.substring(1);
// 10. If ParseText(StringToCodePoints(numberPart), DateMonth) is a List of errors, throw a RangeError exception.
auto parse_result = parse_iso8601(Production::DateMonth, number_part);
// 10. If ParseText(StringToCodePoints(monthCodeDigits), DateMonth) is a List of errors, throw a RangeError exception.
auto parse_result = parse_iso8601(Production::DateMonth, month_code_digits);
if (!parse_result.has_value())
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidMonthCode);
// 11. Set numberPart to ! ToIntegerOrInfinity(numberPart).
auto number_part_integer = MUST(Value(js_string(vm, move(number_part))).to_integer_or_infinity(vm));
// 11. Let monthCodeNumber be ! ToIntegerOrInfinity(monthCodeDigits).
auto month_code_number = MUST(Value(js_string(vm, move(month_code_digits))).to_integer_or_infinity(vm));
// 12. Assert: SameValue(monthCode, BuildISOMonthCode(numberPart)) is true.
VERIFY(month_code_string == build_iso_month_code(number_part_integer));
// 12. Assert: SameValue(monthCode, BuildISOMonthCode(monthCodeNumber)) is true.
VERIFY(month_code_string == build_iso_month_code(month_code_number));
// 13. If month is not undefined and SameValue(month, numberPart) is false, throw a RangeError exception.
if (!month.is_undefined() && month.as_double() != number_part_integer)
// 13. If month is not undefined and SameValue(month, monthCodeNumber) is false, throw a RangeError exception.
if (!month.is_undefined() && month.as_double() != month_code_number)
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidMonthCode);
// 14. Return numberPart.
return number_part_integer;
// 14. Return monthCodeNumber.
return month_code_number;
}
// 12.2.34 ISODateFromFields ( fields, options ), https://tc39.es/proposal-temporal/#sec-temporal-isodatefromfields