beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Handle invalid UTF-8 in Fetch's Body#text()

Browse source
This commit is contained in:
0GreenClover0 2023-05-21 02:20:13 +02:00 committed by Tim Flynn
parent 7d24c13d8b
commit b4c6cddd96
Notes: sideshowbarker 2024-07-17 03:18:29 +09:00 
Author: https://github.com/0GreenClover0
Commit: https://github.com/SerenityOS/serenity/commit/b4c6cddd96
Pull-request: https://github.com/SerenityOS/serenity/pull/18948
Issue: https://github.com/SerenityOS/serenity/issues/18913
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/trflynn89
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Fetch/Body.cpp
View file

@ -9,6 +9,7 @@
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/Error.h>
#include <LibJS/Runtime/PromiseCapability.h>
#include <LibTextCodec/Decoder.h>
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/Bindings/HostDefined.h>
#include <LibWeb/Bindings/MainThreadVM.h>
@ -135,9 +136,14 @@ WebIDL::ExceptionOr<JS::Value> package_data(JS::Realm& realm, ByteBuffer bytes,
case PackageDataType::JSON:
// Return the result of running parse JSON from bytes on bytes.
return Infra::parse_json_bytes_to_javascript_value(realm, bytes);
case PackageDataType::Text:
case PackageDataType::Text: {
// Return the result of running UTF-8 decode on bytes.
return JS::PrimitiveString::create(vm, TRY_OR_THROW_OOM(vm, String::from_utf8(bytes)));
auto decoder = TextCodec::decoder_for("UTF-8"sv);
VERIFY(decoder.has_value());
auto utf8_text = TRY_OR_THROW_OOM(vm, TextCodec::convert_input_to_utf8_using_given_decoder_unless_there_is_a_byte_order_mark(*decoder, bytes));
return JS::PrimitiveString::create(vm, move(utf8_text));
}
default:
VERIFY_NOT_REACHED();
}