beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Lagom: Disable the unused-private-field warning on Lagom's clang builds

Browse source 
With the compilation of LibWeb, there's now quite a few cases where this
warning gets triggered. Rather than trying to fix them all right away,
we simply disable the warning for now.

This workaround was proposed by Andrew Kaster and BertalanD who promised
to open an issue about it!
This commit is contained in:
DexesTTP 2022-04-30 20:04:30 +02:00 committed by Linus Groh
parent 915ac9edd6
commit b388aa7876
Notes: sideshowbarker 2024-07-17 10:34:49 +09:00 
Author: https://github.com/Dexesttp
Commit: https://github.com/SerenityOS/serenity/commit/b388aa7876
Pull-request: https://github.com/SerenityOS/serenity/pull/13473
Issue: https://github.com/SerenityOS/serenity/issues/10968
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/kleinesfilmroellchen
Reviewed-by: https://github.com/krkk
Reviewed-by: https://github.com/linusg ✅
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Meta/Lagom/CMakeLists.txt
View file

@ -102,6 +102,10 @@ endif()
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang$") if (CMAKE_CXX_COMPILER_ID MATCHES "Clang$")
# Clang's default constexpr-steps limit is 1048576(2^20), GCC doesn't have one # Clang's default constexpr-steps limit is 1048576(2^20), GCC doesn't have one
add_compile_options(-Wno-overloaded-virtual -Wno-user-defined-literals -fconstexpr-steps=16777216) add_compile_options(-Wno-overloaded-virtual -Wno-user-defined-literals -fconstexpr-steps=16777216)
# FIXME: Re-enable this check when the warning stops triggering, or document why we can't stop it from triggering.
# For now, there is a lot of unused private fields in LibWeb that trigger this that could be removed.
# See issue #14137 for details
add_compile_options(-Wno-unused-private-field)
if (ENABLE_FUZZERS_LIBFUZZER) if (ENABLE_FUZZERS_LIBFUZZER)
add_compile_options(-fsanitize=fuzzer) add_compile_options(-fsanitize=fuzzer)