beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Make Formatter for NonnullOwnPtr<T> format the T

Browse source 
This mirrors the behavior of NonnullRefPtr<T>. If you want to format
the pointer address, call .ptr() on it.
This commit is contained in:
Andreas Kling 2023-08-25 17:39:54 +02:00
parent f8e5df7a99
commit b256e52586
Notes: sideshowbarker 2024-07-17 07:31:31 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/b256e52586
Pull-request: https://github.com/SerenityOS/serenity/pull/20770
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/MacDue
2 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
AK/NonnullOwnPtr.h
View file

@ -196,7 +196,16 @@ inline void swap(NonnullOwnPtr<T>& a, NonnullOwnPtr<U>& b)
a.swap(b);
}
template<Formattable T>
struct Formatter<NonnullOwnPtr<T>> : Formatter<T> {
ErrorOr<void> format(FormatBuilder& builder, NonnullOwnPtr<T> const& value)
{
return Formatter<T>::format(builder, *value);
}
};
template<typename T>
requires(!HasFormatter<T>)
struct Formatter<NonnullOwnPtr<T>> : Formatter<T const*> {
ErrorOr<void> format(FormatBuilder& builder, NonnullOwnPtr<T> const& value)
{

17
Tests/AK/TestNonnullOwnPtr.cpp
View file

@ -9,6 +9,7 @@
#include <AK/DeprecatedString.h>
#include <AK/NonnullOwnPtr.h>
#include <AK/OwnPtr.h>
#include <AK/String.h>
TEST_CASE(destroy_self_owning_object)
{
@ -32,3 +33,19 @@ TEST_CASE(destroy_self_owning_object)
object_ptr->inner = make<SelfOwning::Inner>(object.release_nonnull());
object_ptr->inner = nullptr;
}
struct Foo { };
template<>
struct AK::Formatter<Foo> : Formatter<StringView> {
ErrorOr<void> format(FormatBuilder& builder, Foo const&)
{
return Formatter<StringView>::format(builder, ":^)"sv);
}
};
TEST_CASE(formatter)
{
auto foo = make<Foo>();
EXPECT_EQ(MUST(String::formatted("{}", foo)), ":^)"sv);
}